Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
Thanks for noticing that, I didn't realize it would cross-link. That's not
what I was hoping for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/239
Hey @jvwing & @joewitt
James, your comment listing the associated JIRA legal issue actually had
the nice side effect of getting included in the associated issue. A response
is here:
https://i
Ahh just saw this. Will take a look into licensing.
On Jun 8, 2016 2:31 PM, "jvwing" wrote:
> Github user jvwing commented on the issue:
>
> https://github.com/apache/nifi/pull/239
>
> @joewitt, would you please help us with the licensing/notice
> requirements for using the Kinesis Clien
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
@mans2singh thanks for your recent updates, the property descriptor
improvements look good to me.
As far as property descriptors for data size ("10 KB") and duration ("1
minute") - I believe
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
@joewitt, would you please help us with the licensing/notice requirements
for using the Kinesis Client Library and Kinesis Producer Library? The Kinesis
libraries are licensed under the [Amazon Softwar
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
@jvwing -
I've added displayName to PropertyDescriptor and updated name based on your
feedback.
I've not tried nifi on aws and mostly run it locally on my laptop that is
why I w
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
@mans2singh, the error messages did not contain anything helpful that
indicated it was a memory issue, just the text
`com.amazonaws.services.kinesis.producer.DaemonException: The child process has
been
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
@jvwing -
Thanks again for your thorough review.
Just for my own learning, if there any pointers in the errors that
indicated it was a memory issue, please let me know. Also, is there any
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
It appears that my errors were caused by memory constraints on the KPL.
With a larger EC2 instance, I was able to run at the provisioned throughput
threshold without the KPL process crashing. The proc
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
The suggested use of `name` and `displayName` on PropertyDescriptors has
been shared around a lot the last few days. You can read the [backstory
thread](http://mail-archives.apache.org/mod_mbox/nifi-de
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
Hey @jvwing
I've made the property name changes you recommended and corrected
maxBufferedTimeInterval - it was indeed millis and values were different from
what I had. I've also added all
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
I also recommend some modifications to the property definitions in both
AbstractKinesisConsumer and AbstractKinesisProducer:
* Use `name` as a key and `displayName` for the UI text, rather t
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
I have shared some [recommended edits to the property labels and doc
text](https://github.com/jvwing/nifi/commit/e431a9665ce5c2cbbabf2605cc088108ed74e7c5),
please take a look.
---
If your project
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
Thanks for your latest changes to the error handling. The changes look OK,
I don't think we need the failure relationship. The integration tests for
PutKinesisStream and GetKinesisStream both worked f
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
@jvwing -
I've updated the code to catch and log the exception and continue
processing kinesis records as you had recommended.
I can remove REL_FAILURE since it is not being used
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
Ok - I will add more logging, let me know if there is any other observation
you have.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
Checkpointing after catching an exception would keep things moving, I can
see the benefit there. But what is the advantage of creating a failed FlowFile
over just logging the exception? What would a u
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
Hi @jvwing:
Regarding exception handling - Kinesis will automatically handle retrying
if there is kinesis client error from the last checkpoint created in the
GetKinesisStream.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/239
Thanks, @mans2singh, I will review the changes. I don't think the AppVeyor
build is reliable, there don't appear to be any recent successful builds.
For GetKinesisStream exceptions, I think you
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
Hi @jvwing
Just wanted to check if you were able to test the processors and if you
have any additional review comments/recommendations for me.
Thanks
Mans
---
If your
20 matches
Mail list logo
