[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172874349 Build looks good. No more artifacts showing up in user home directory. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172875249 Thanks for merging this PR. Do we similarly modify all of the other TestJdbc* to take a TemporaryFolder ? --- If your project is set up for it, you can reply to this

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172880667 I wasn't aware of any issues with the other JDBC tests. This JIRA was created to specifically address the tests resources being created in the user's HOME directory. If

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-16 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172197578 I agree that the file should not be created relative to the HOME directory, but can we use something relative to the local target/ directory instead of an absolute

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-16 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172238487 @mattyb149 I think the reason it had an absolute path was due to the below error from the H2 driver: org.h2.jdbc.JdbcSQLException: A file path that is implicitly