Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-173351611
Jeremy,
I've been reviewing this and I made a handful of minor changes:
* Copied licensing information to the nar - it was already present in
nifi-assembly. J
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-170978164
@jdye64 I left a lot of inline comments while doing a code review. Mostly
just pointing out either naming conventions that we should strive to be
consistent with, or poin
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482412
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482104
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49482019
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/ModifyHTMLElement.java
---
@@ -0,0 +1,164 @@
+/*
+ * Li
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481748
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319 @@
+/*
+ * L
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481551
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319 @@
+/*
+ * L
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481366
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java
---
@@ -0,0 +1,319 @@
+/*
+ * L
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49481210
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/AbstractHTMLTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Lice
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480961
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480952
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480617
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480382
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480407
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480317
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479161
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480077
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480004
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479943
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49479814
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licen
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49478696
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49478637
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-168541446
added more comments on the NIFI-1156 ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r45008293
--- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/pom.xml ---
@@ -0,0 +1,59 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-15742
MIT is perfectly fine both for source and binary dependency. Details can
be found here with links to all sorts of goodness
"https://nifi.apache.org/licensing-guide.html";
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-157221978
General question primarily for NiFi leadership team. JSoup MIT License -
http://jsoup.org/license
Are there any conflicts?
---
If your project is set up for it, you can
GitHub user jdye64 opened a pull request:
https://github.com/apache/nifi/pull/124
NIFI-1156: HTML Parsing Processors Bundle
NIFI-1156: HTML Parsing Processors Bundle. GetHTMLElement,
ModifyHTMLElement, and PutHTMLElement
You can merge this pull request into a Git repository by runn
28 matches
Mail list logo
