Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/131#issuecomment-159345927
@markap14 @trkurc The PR comments were addressed. I was hoping to get
Kafka embedded server with this commit as well (for testing), but so far it
doesn't appear to be very
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/131#issuecomment-159052094
@trkurc @markap14 @joewitt
Guys, this one is strictly for review as I am still working on adding the
same dynamic properties logic for PutKafka. But since it contains
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45687929
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -203,26 +205,69 @@
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45687909
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -70,6 +70,10 @@
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45688132
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -45,13 +45,18 @@
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/131#discussion_r45688059
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -45,13 +45,18 @@
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/131#issuecomment-159129775
Thanks @markap14! indeed it's a bit dirty and I have to polish it for
style-check, comments etc. As I mentioned in commit message somewhere this was
primarily for initial
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/129#issuecomment-158542457
@trkurc @joewitt @markap14
Guys, please see the updated commit. This one has a bit more work as it
includes some polishing since we discovered few more issues, one
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
10 matches
Mail list logo
