[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-22 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173939440 @trkurc I understand and thank you for merging it. That said, there are improvements efforts under way which hopefully would address all of our concerns. --- If your proj

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-21 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173795089 Not sure that I agree, but I do agree this is a step in the right direction, so I'll merge it in. --- If your project is set up for it, you can reply to this email and hav

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-21 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173604806 @trkurc I do see your point, so let me throw something else at you. The _URI_VALIDATOR_ simply validates based on success of this ```new URI(input);``` and we can certainly

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-20 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173426598 @olegz - to sort of summarize, I definitely understand the issue with the uri and only being able to fully verify "at runtime", it also makes sense to deal with obvious mi

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-19 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173043643 reviewing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/167 NIFI-1378 fixed JMS URI validation simplified JmsFactory check for SSL and scheme-less URIs ensured URI validation is handled by ActiveMqConnectionFactory ensured informative error messages are s