[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-02-18 Thread michalklempa
GitHub user michalklempa opened a pull request: https://github.com/apache/nifi/pull/235 NIFI-1518 InferAvroSchema note has an option to set CSV delimiter Code transliterated from ConvertCSVToAvro processor, new Property DELIMITER (default ',') added. You can merge this pull request

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-02-18 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/235#issuecomment-185679941 reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-02-18 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/235#discussion_r53414564 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchema.java --- @@ -51,6 +51,7 @@ pu

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-02-18 Thread michalklempa
Github user michalklempa commented on a diff in the pull request: https://github.com/apache/nifi/pull/235#discussion_r53425835 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchema.java --- @@ -51,6 +51,7

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-03-10 Thread JPercivall
Github user JPercivall commented on the pull request: https://github.com/apache/nifi/pull/235#issuecomment-195030029 @trkurc what was the result of your review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-03-10 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/235#issuecomment-195092832 @JPercivall - code looks good, just need to contrib-check, do some quick manual testing and merge --- If your project is set up for it, you can reply to this email and hav

[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...

2016-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable