[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172864860 +1 Went ahead and merged the proposed changes for the build infrastructure. Specifics for this integration test can be updated as needed. --- If your project is set up f

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172669320 Gotcha. There were some good suggestions on the related thread on the mailing list but there are limited classes that fall into this category at this time. Not necessarily s

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172668316 Yep, I realize this PR was just trying to establish the baseline and create the build infrastructure. I can certainly +1 that aspect. I was just wondering if this sort of

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172666378 Sorry went off on a tangent on the previous part. In favor of that but curious as to what the destination should be. Didn't do the integration test classes myself but can co

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172665743 Highlighting the existence of the new profile is a good idea and we should do that. However, I was specifically referring to the AWS integration tests that are part of th

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172661289 Not opposed but not sure how to best accomplish this. A section in the dev or contrib guide talking about how to activate and or what is currently present seem reasonable? A

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172657153 The build infrastructure changes look good. I realize the motivation for this ticket was establishing this baseline. However, I wanted to try to run the integration tests

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172646806 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en