[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-216962878 Awesome, thanks again!! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-216918354 Merged to 0.x and master. Fix Versions applied for 0.7 and 1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-216916238 @adamonduty Had some time to scope it out. Things are looking great for the templates and items I laid out from before. Looks like rebase went fine, so I shall work on

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-216860573 @adamonduty Thanks for the explanation and your thoughts, very helpful and very much appreciated. I think things will be a little clearer now that the increment item is

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-216751696 @apiri Thanks for the review! All your comments should be addressed except the state management pieces. State management should work more or less like

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991389 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java --- @@ -46,7 +46,7 @@

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991342 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java --- @@ -46,7 +46,7 @@

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991321 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/*

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991245 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/*

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991253 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/*

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r61991205 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/*

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-213660402 Overall, seems to function well with some minor adjustments needed. Would like to hash out some of the items with managing state. Thanks for tackling this, we are

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822522 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822467 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java --- @@ -46,7 +46,7 @@

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822400 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822342 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822275 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r60822174 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-213652173 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-211711893 I can, but it might not be until later this week. On Mon, Apr 18, 2016 at 11:26 PM, Joe Witt wrote: > Anyone in a good position

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-211711025 Anyone in a good position to test/validate this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user adamonduty commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-187523459 @jskora Nice catch, I fixed the state issue and it seemed to work in my tests. I also rebased against master, added the recent proxy attributes, and changed the

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r53674055 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,230 @@ +/* +