thanks mike/adam. Doing now. Hold onto your source codes.
On Thu, Nov 12, 2015 at 5:54 PM, Adam Taft wrote:
> git revert is your friend.
>
> https://git-scm.com/docs/git-revert
>
> It's not "rollback" -- it's another new commit with the changes reinstated.
>
> On Thu, Nov 12, 2015 at 5:45 PM, J
git revert is your friend.
https://git-scm.com/docs/git-revert
It's not "rollback" -- it's another new commit with the changes reinstated.
On Thu, Nov 12, 2015 at 5:45 PM, Joe Witt wrote:
> ok - will undo the commit. I get to learn a new git trick? Or just
> add them back? I must admit I'm
"git revert " should do what you need it to do.
On Thu, Nov 12, 2015 at 4:45 PM, Joe Witt wrote:
> ok - will undo the commit. I get to learn a new git trick? Or just
> add them back? I must admit I'm not sure how best to do that.
>
> On Thu, Nov 12, 2015 at 5:39 PM, Brandon DeVries wrote:
>
ok - will undo the commit. I get to learn a new git trick? Or just
add them back? I must admit I'm not sure how best to do that.
On Thu, Nov 12, 2015 at 5:39 PM, Brandon DeVries wrote:
> I would undo the removal for now, and make a point of doing the test
> properly. I don't like the idea of r
I would undo the removal for now, and make a point of doing the test
properly. I don't like the idea of removing the test and saying we'll add
new ones eventually (those sorts of things tend to not happen...).
Brandon
On Thu, Nov 12, 2015 at 5:36 PM Tony Kurc wrote:
> Shipping built jars that te
Shipping built jars that tests depend on is icky. Not shipping the source
to those tests is ickier.
On Nov 12, 2015 5:34 PM, "Joe Witt" wrote:
> i think we should kill those tests which depend on the build of those
> jars personally. But if the view is to undo the removal of those
> three classe
All of the current ExecuteStreamCommand tests rely on those jars.
- - - - - -
Joseph Percivall
linkedin.com/in/Percivall
e: joeperciv...@yahoo.com
On Thursday, November 12, 2015 5:34 PM, Joe Witt wrote:
i think we should kill those tests which depend on the build of those
jars personally
i think we should kill those tests which depend on the build of those
jars personally. But if the view is to undo the removal of those
three classes i can do that.
Thanks
Joe
On Thu, Nov 12, 2015 at 5:32 PM, Tony Kurc wrote:
> Do you plan to undo the removal?
> On Nov 12, 2015 4:46 PM, "Joe Wit
Do you plan to undo the removal?
On Nov 12, 2015 4:46 PM, "Joe Witt" wrote:
> well that explains these goofball classes I deleted the other day
>
> https://issues.apache.org/jira/browse/NIFI-1134
>
> These classes were used to make those Jars. Those jars are used to
> test execute command. We'v
well that explains these goofball classes I deleted the other day
https://issues.apache.org/jira/browse/NIFI-1134
These classes were used to make those Jars. Those jars are used to
test execute command. We've now removed the source that was floating
randomly. We need the built to automatically
Tony,
I did a bit of digging through the history and the jars were a part of the
initial code import so unless if Joe or someone else knows where they came from
then we may be out of luck.
Joe
- - - - - -
Joseph Percivall
linkedin.com/in/Percivall
e: joeperciv...@yahoo.com
On Wednesday,
All, I was code reviewing and something occurred to me. This raised my
eyebrow:
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteStreamCommand.java#L63
If I'm reading it right, the
12 matches
Mail list logo
