Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread James Wing
I'm having trouble with a failing unit test in nifi-standard-processors, new in a recent merge. Any helpful tips would be appreciated. Failed tests: TestEncryptContent.testShouldValidatePGPPublicKeyringExists:254 ''Public Keyring File' is invalid because Invalid Public Keyring File

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Thad Guidry
yeah, I just fixed it locally... but looks like a patch is needed to handle the output expected on Windows systems, as I did below. testShouldValidatePGPPublicKeyringExists() String expectedResult = " (No such file or directory)"; // String expectedResultOnWindows = " (The

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Andy LoPresto
Sorry, after looking at the code, we don’t get the actual exception instance from the validation results, but the message does contain the FQ exception type. `vr.toString() == "'Public Keyring File' is invalid because Invalid Public Keyring File

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Thad Guidry
Andy, YUP ! Standard FNF exception across the board works for me. Thad +ThadGuidry

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread James Wing
Not that I understand the module, but it does seem like "java.io.FileNotFoundException" would be safer. Thank you all for your help, I'll ignore the test for now using Thad's method and move on. Should I create a ticket? On Tue, Jan 12, 2016 at 3:24 PM, Andy LoPresto

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Andy LoPresto
Thad, Yes, looking for the FQ exception name in the validation result string as it seems to be platform independent that the class name is included in the exception toString(). https://github.com/apache/nifi/commit/1e3663c8e7f7a0a33e8021e6c430271a7fb3f816

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Tony Kurc
There should be a ticket, it would be great to determine if there is "a better way" longer term, but I'm in favor of a fix that gets merged that gets the windows build working, and explore other options which might be less fragile. I can likely review, test and merge a patch quickly. I'm reminded

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Andy LoPresto
Made the change and it’s in a PR with related changes. Thanks Thad and James for finding this. Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 3:32 PM, Thad Guidry wrote: > > Andy, > >

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Tony Kurc
You're proposing looking for that as a substring of the error message? On Tue, Jan 12, 2016 at 6:24 PM, Andy LoPresto wrote: > Sorry, after looking at the code, we don’t get the actual exception > instance from the validation results, but the message does contain the

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Andy LoPresto
James, I’ll make a Jira ticket and post it here. Thanks. Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 3:36 PM, Andy LoPresto wrote: > > Thad, > > Yes, looking for the FQ

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

2016-01-12 Thread Tony Kurc
I merged in the change after confirming it tested fine on windows 10 and ubuntu 14.04 On Tue, Jan 12, 2016 at 7:19 PM, Andy LoPresto wrote: > Ok, thanks Tony. > > Andy LoPresto > alopresto.apa...@gmail.com > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B