Mike,
Seeing a pretty stunning flood of JIRAs for 'Refactor nifi-bla to use
JUnit 5' and I'm guessing we'll see the same in terms of PRs. This is
a really high administrative overhead approach to this.
Why not break this into one or maybe a few JIRAs/PRs total?
Thanks
Maybe this is an exception to the single squashed commit guidance for the
initial pull?
I assume the intent is to make incremental progress and not have a PR with a
hundred files affected, but if the different module changes corresponded to a
different commit, GH will make it easy enough to hav
Joey
I personally dont care all that much about the number of commits in PR
- I think that rule is sort of soft already.
I dont think there is any inherent value in having a single module per
JIRA (and PR or PR commit) on this. These can be done in much coarser
grained chunks. It will have to b
I broke up the tickets because it is A LOT of individual tasks that
can break the overall build and wanted to scope the work appropriately
so that people looking for a chance to contribute could snatch up a
few easy wins.
I'm still going to take point on making the changes, but the plan
going forw
Mike,
Thanks for moving things forward on the JUnit 5 migration. I posted a
couple comments on the PR for nifi-commons (NIFI-9080) with concerns
related to breaking tests and perpetuating ignored unit tests.
Summarizing in this thread for general discussion, I am concerned about
breaking unit tes
Hi all,
JUnit 5 certainly contains a number of benefits, so I’m glad to see some
interest and effort around it.
As long as we are taking the time to update tests in each module and line up
reviewers for these bulk refactoring, I agree with David that we should make
improvements aside from jus
presumably PRs to follow for junit-5
migration?
Hi all,
JUnit 5 certainly contains a number of benefits, so I’m glad to see some
interest and effort around it. br/> <
As long as we are taking the time to update tests in each module and line
up reviewers for these bulk refactoring, I agree with
David and I had a discussion on GitHub, and I've been standardizing
the changes along lines similar to what you described about ripping
out anti-patterns. The reviews should be fairly straight forward
because about 80% of the changes are just imports getting changed.
On Tue, Aug 31, 2021 at 6:06 P
