Joe,
Thank you for expounding on your original response. I think that clarifies
expectations a great deal. I totally agree, and do those types of reviews
myself.
As a non-committer who does pr’s and reviews I guess what I was saying is
that even if I and someone who entered the issue in jira
Otto
I wrote: "Anyone can do a review of the code and build and feasibility of a
change. It only requires commit privileges to actually merge something."
You then wrote "Anyone can review, but you need at least one committer
approval / review to get a pr landed."
While similar, there is an
Anyone can review, but you need at least one committer approval / review
to get a pr landed.
On October 8, 2020 at 12:17:17, Joe Witt (joe.w...@gmail.com) wrote:
Hello
Anyone can do a review of the code and build and feasibility of a change.
It only requires commit privileges to actually
I think the question from Phillip about how to make PR review easier is a great
one. For any PR, providing a sample flow which exercises the change is a big
time saver already. Demonstrating that unit tests are added/updated, asserting
that license considerations have been addressed, and that
Hello Joe, Phillip and Pierre,
I am really happy we are having this discussion.
I (and very likely other contributers) was under the impression that only
reviews by committers/PMC members (i.e. more senior nifi dev community members)
had any real weight, so that is why I have not been reviewing
Hello
Anyone can do a review of the code and build and feasibility of a change.
It only requires commit privileges to actually merge something.
Doing the hard work of reviewing/testing the PRs is a *great* way to earn
merit.
Much of the PRs that tend to hang around are from people contributing
Pierre,
I think this discussion brings up a valid conversation point. At some point
a PMC member needs to approve the merge request, so from a contributors
level what can we do to make that merge both easier and/or more likely to
happen. That and how the community can help filter down the ever
Nissim,
Thanks a lot for your contribution but there are 277 pull requests opened
at this time. This is a community effort, and if you expect people to
review your PRs, you'd have to also try reviewing PRs opened by others in
the community. Otherwise this will need to wait for someone with some
Second attempt...
Hello NiFi team,
Could someone respond to this email.
Thanks,
Nissim Shiman
On Monday, October 5, 2020, 11:01:57 AM EDT, Nissim Shiman
wrote:
Hello NiFi team,
Could someone review the pull request for NIFI-7738
(https://issues.apache.org/jira/browse/NIFI-7738),
Hello NiFi team,
Could someone review the pull request for NIFI-7738
(https://issues.apache.org/jira/browse/NIFI-7738), that was put in 5 days ago?
(Provenance Search Events - add feature to allow inverse query)
One case this will come in handy is if a particular flowfile has an issue and
goes
10 matches
Mail list logo
