Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-120764934
Another way to fix the threading issue is to validate the sinks and sources
are safe and wrap them in first-class processors that allow threading even if
the
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-120764330
+1. Thanks Joey!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34380128
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34178232
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34176343
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/ConvertAvroSchema.java
---
@@ -0,0
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34176166
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34175566
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34175286
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34175017
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/ConvertAvroSchema.java
---
@@ -0,0
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34174772
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/ConvertAvroSchema.java
---
@@ -0,0
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34174588
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/ConvertAvroSchema.java
---
@@ -0,0
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34174435
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34174088
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34173977
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34173699
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34173302
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34173083
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/70#discussion_r34172888
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AvroRecordConverter.java
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116860830
@joewitt, looks like the problem is that the accumulated error messages are
out of order. This is a result of moving from the multimap to a plain hashmap.
I&#x
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116841432
No problem, I wanted to get it into the release. Thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116838575
I think this is ready to go. I'm not concerned with the error tracking
because we keep to a pretty reasonable format, "General error: specific data"
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-116823666
I think thread-local would be okay because the thread doesn't change while
the process is running. In onTrigger, you would first set the thread's sess
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116813026
Nevermind, I was in the wrong branch. I've fixed the bug and will have this
updated shortly. Thanks!
---
If your project is set up for it, you can reply to
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116809640
@joewitt, I get an error that it converted 3 rows successfully instead of
2. I'm not sure I understand why that isn't the correct behavior. Shouldn'
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116218005
Thanks for taking a look, Joe.
I implemented the changes as you suggested. I kept the incompatible
relationship because when we can recover the original
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-116191838
> Is there any service provider construct or similar mechanism whereby we
could provide a dropdown of identified sources and sinks
I think this
GitHub user rdblue opened a pull request:
https://github.com/apache/incubator-nifi/pull/69
NIFI-738: Improve error handling for CSV and JSON conversion.
Changes:
* Send bad record information on the "incompatible" relationship
* Use an attribute, "errors&
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32173669
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-110921016
+1
Looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32168957
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32168616
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32168462
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32167493
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r32166926
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/51#issuecomment-110475354
@joey did you find a good way to have a reference to a `ProcessSession`
outside of the `onTrigger` method?
---
If your project is set up for it, you can reply to
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31858031
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31857427
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31857255
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31856990
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSourceProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31855713
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31855669
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/51#discussion_r31855489
--- Diff:
nifi/nifi-nar-bundles/nifi-flume-bundle/nifi-flume-processors/src/main/java/org/apache/nifi/processors/flume/FlumeSinkProcessor.java
GitHub user rdblue opened a pull request:
https://github.com/apache/incubator-nifi/pull/36
NIFI-428: Update to Kite 1.0.0.
Kite 1.0.0 fixes the JSON and CSV readers so they no longer need to be
in NiFi.
You can merge this pull request into a Git repository by running
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/24#issuecomment-75162252
I've updated the pull request after Mark's comments. Thanks for the great
suggestions and help!
---
If your project is set up for it, you can reply to
Github user rdblue commented on the pull request:
https://github.com/apache/incubator-nifi/pull/24#issuecomment-74789039
Thanks for the reviews! I've update the PR with the needed changes. I also
noticed that I was using the deprecated annotations, so I updated those as well.
-
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/24#discussion_r24837278
--- Diff: nifi/nifi-nar-bundles/nifi-kite-bundle/pom.xml ---
@@ -0,0 +1,60 @@
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/24#discussion_r24837243
--- Diff: nifi/nifi-nar-bundles/nifi-kite-bundle/pom.xml ---
@@ -0,0 +1,60 @@
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/24#discussion_r24837051
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/kitesdk/data/spi/filesystem/CSVFileReaderFixed.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/24#discussion_r24836941
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/KiteStorageProcessor.java
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/incubator-nifi/pull/24#discussion_r24836760
--- Diff:
nifi/nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/JSONFileReader.java
---
@@ -0,0
GitHub user rdblue opened a pull request:
https://github.com/apache/incubator-nifi/pull/24
NIFI-238: Add Kite processors.
Includes:
* KiteStorageProcessor - store Avro files in a Kite dataset
* KiteCSVToAvroProcessor - convert CSV to Avro for storage
51 matches
Mail list logo
