Re: Nutch codebase formatting

2023-10-29 Thread Sebastian Nagel
Hi Lewis, >> whether we need a Nutch custom code style at all… why don’t we just use >> some other existing style and then enforce it? Enforcing: yes! However, I would try hard to keep the changes on a reasonable minimum. For example, if we change the indentation, almost every code line is

[jira] [Commented] (NUTCH-3014) Standardize Job names

2023-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUTCH-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780720#comment-17780720 ] ASF GitHub Bot commented on NUTCH-3014: --- sebastian-nagel commented on code in PR #789: URL:

Re: [PR] NUTCH-3014 Standardize Job names [nutch]

2023-10-29 Thread via GitHub
sebastian-nagel commented on code in PR #789: URL: https://github.com/apache/nutch/pull/789#discussion_r1375421979 ## src/java/org/apache/nutch/crawl/CrawlDbReader.java: ## @@ -812,7 +811,7 @@ public CrawlDatum get(String crawlDb, String url, Configuration config)