[jira] [Commented] (NUTCH-3025) urlfilter-fast to filter based on the length of the URL

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUTCH-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783563#comment-17783563 ] ASF GitHub Bot commented on NUTCH-3025: --- jnioche commented on PR #796: URL:

Re: [PR] [NUTCH-3025] urlfilter-fast to filter based on the length of the URL [nutch]

2023-11-07 Thread via GitHub
jnioche commented on PR #796: URL: https://github.com/apache/nutch/pull/796#issuecomment-1798221743 Writing a test for this thing is an absolute pain. The way the filters are used for real is that their method setConf is called and the rules are loaded using _getConfResourceAsReader_, i.e.

[jira] [Commented] (NUTCH-3025) urlfilter-fast to filter based on the length of the URL

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUTCH-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783544#comment-17783544 ] ASF GitHub Bot commented on NUTCH-3025: --- jnioche commented on code in PR #796: URL:

Re: [PR] [NUTCH-3025] urlfilter-fast to filter based on the length of the URL [nutch]

2023-11-07 Thread via GitHub
jnioche commented on code in PR #796: URL: https://github.com/apache/nutch/pull/796#discussion_r1384621727 ## src/plugin/urlfilter-fast/src/java/org/apache/nutch/urlfilter/fast/FastURLFilter.java: ## @@ -97,9 +97,17 @@ public class FastURLFilter implements URLFilter {

[jira] [Commented] (NUTCH-3025) urlfilter-fast to filter based on the length of the URL

2023-11-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/NUTCH-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783533#comment-17783533 ] ASF GitHub Bot commented on NUTCH-3025: --- sebastian-nagel commented on code in PR #796: URL:

Re: [PR] [NUTCH-3025] urlfilter-fast to filter based on the length of the URL [nutch]

2023-11-07 Thread via GitHub
sebastian-nagel commented on code in PR #796: URL: https://github.com/apache/nutch/pull/796#discussion_r1384536930 ## src/plugin/urlfilter-fast/src/java/org/apache/nutch/urlfilter/fast/FastURLFilter.java: ## @@ -97,9 +97,17 @@ public class FastURLFilter implements URLFilter {