[GitHub] [nutch] lewismc commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-17 Thread GitBox
lewismc commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1014841784 @prakharchaube would be great to get this into master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nutch] lewismc commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-06 Thread GitBox
lewismc commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006873161 What about [StringUtil.java](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/util/StringUtil.java) -- This is an automated message from the Apache Git Servi

[GitHub] [nutch] lewismc commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-05 Thread GitBox
lewismc commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006175869 @prakharchaube > I see the same String message is further used as... That was bad of me. i should have looked another few lines down! > What I can do is use Str

[GitHub] [nutch] lewismc commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-05 Thread GitBox
lewismc commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006021514 Hi @prakharchaube sterling job! Please consider the following ``` //parameterized logging... see https://www.slf4j.org/faq.html#logging_performance LOG.error("CrawlDb up