[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-18 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1015495906 @lewismc @sebastian-nagel done the changes please review, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-17 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1015009448 @lewismc apologies for the delay I've fallen ill which is why I'm unable to work on it but I'll will finish it as soon as I'm recovered. Tentatively by this Sunday. -- Thi

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-10 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1009130088 @sebastian-nagel thanks for the suggestion, not to worry the stack trace would still show the logs origin as the Job Classes. > Maybe [NutchJob](https://github.com/apa

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-06 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006884336 hmm, can add it in that class as well! Thanks, @lewismc, will make the amends and commit. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-06 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006847258 @lewismc Surely. Something I noticed is that all error messages have a common format which is "%s job did not succeed, job id: %s job status: %s ,reason: %s" so I was

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

2022-01-05 Thread GitBox
prakharchaube commented on pull request #721: URL: https://github.com/apache/nutch/pull/721#issuecomment-1006040395 @lewismc I agree we should use parameterized logging however, I see the same String _message_ is further used as throw new RuntimeException(message); What I can do i