[ https://issues.apache.org/jira/browse/NUTCH-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140167#comment-13140167 ]
Ferdy edited comment on NUTCH-1098 at 10/31/11 1:49 PM: -------------------------------------------------------- +1 for encoding spaces into %20, both in file and query. (Although encoding spaces in the query part into 'plus' is also fine with me.) +1 for uppercasing escaped chars. (%1f --> %1F) I propose to split this issue into separate issues, as this makes discussing the individual features a lot easier. (Also making it easier to commit changes that have smaller overall impact such as the %20 feature). Also, the latest patch still has some flaws. (Wrong path as files are prefixed with 'a/' and some indent issues here and there.) was (Author: ferdy.g): +1 for encoding spaces into %20, both in file and query. (Although encoding spaces in the query part into `+` is also fine with me.) +1 for uppercasing escaped chars. (%1f --> %1F) I propose to split this issue into separate issues, as this makes discussing the individual features a lot easier. (Also making it easier to commit changes that have smaller overall impact such as the %20 feature). Also, the latest patch still has some flaws. (wrong path as files are prefixed with 'a/ and some indent issues here and there.). > better url-normalizer basic > --------------------------- > > Key: NUTCH-1098 > URL: https://issues.apache.org/jira/browse/NUTCH-1098 > Project: Nutch > Issue Type: Improvement > Components: fetcher > Affects Versions: 1.3 > Environment: Any > Reporter: Radim Kolar > Assignee: Markus Jelsma > Labels: encoding, url > Fix For: 1.5 > > Attachments: patch-urlnormalizer.diff > > Original Estimate: 4h > Remaining Estimate: 4h > > Basic URL normalizer lacks 2 important features > Encode space in URL into %20 to unbreak httpclient and possibly others who do > not expect space inside URL > Ability to decode %33 encoding in URL. This is important for avoiding > duplicates -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira