[ 
https://issues.apache.org/jira/browse/NUTCH-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated NUTCH-2910:
----------------------------------------
    Description: 
The FetchItemQueues overloaded constructor [attempts to obtain the 
*NON-EXISTENT*  _fetcher.timelimit_ configuration 
property|https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/fetcher/FetchItemQueues.java#L84].


{code:java}
this.timelimit = conf.getLong("fetcher.timelimit", -1);
{code}

As you can see a default value of -1 is provided. The first parameter is 
however wrong. It should instead reference the following configuration property.


{code:xml}
<property>
  <name>fetcher.timelimit.mins</name>
  <value>-1</value>
  <description>This is the number of minutes allocated to the fetching.
  Once this value is reached, any remaining entry from the input URL list is 
skipped 
  and all active queues are emptied. The default value of -1 deactivates the 
time limit.
  </description>
</property>
{code}

Note, *_fetcher.timelimit.mins_*

I think that this essentially means the Fetcher has no time limit which is 
ofcourse not desired.



  was:
The FetchItemQueues overloaded constructor [attempts to obtain the 
*NON-EXISTENT*  _fetcher.timelimit_ configuration 
property|https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/fetcher/FetchItemQueues.java#L84].


{code:java}
this.timelimit = conf.getLong("fetcher.timelimit", -1);
{code}

As you can see a default value of -1 is provided. The first parameter is 
however wrong. It should instead reference the following configuration property.


{code:xml}
<property>
  <name>fetcher.timelimit.mins</name>
  <value>-1</value>
  <description>This is the number of minutes allocated to the fetching.
  Once this value is reached, any remaining entry from the input URL list is 
skipped 
  and all active queues are emptied. The default value of -1 deactivates the 
time limit.
  </description>
</property>
{code}

Note, *_fetcher.timelimit.mins_*




> FetchItemQueues overloaded constructor also interprets fetcher timeout as -1 
> e.g. no-timeout.
> ---------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-2910
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2910
>             Project: Nutch
>          Issue Type: Bug
>          Components: fetcher
>    Affects Versions: 1.18
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.19
>
>
> The FetchItemQueues overloaded constructor [attempts to obtain the 
> *NON-EXISTENT*  _fetcher.timelimit_ configuration 
> property|https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/fetcher/FetchItemQueues.java#L84].
> {code:java}
> this.timelimit = conf.getLong("fetcher.timelimit", -1);
> {code}
> As you can see a default value of -1 is provided. The first parameter is 
> however wrong. It should instead reference the following configuration 
> property.
> {code:xml}
> <property>
>   <name>fetcher.timelimit.mins</name>
>   <value>-1</value>
>   <description>This is the number of minutes allocated to the fetching.
>   Once this value is reached, any remaining entry from the input URL list is 
> skipped 
>   and all active queues are emptied. The default value of -1 deactivates the 
> time limit.
>   </description>
> </property>
> {code}
> Note, *_fetcher.timelimit.mins_*
> I think that this essentially means the Fetcher has no time limit which is 
> ofcourse not desired.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to