Re: Should we relax precheck a little bit?

On Tue, Mar 10, 2020 at 1:17 AM Gregory Nutt wrote: > > > > - Fixing the entire file we touch helps makes things better overall even > > though its painful in the short run. > > - Having a tool that produces accurate style recommendations is very > > important— it's hard to know wh

Build failed in Jenkins: NuttX-Nightly-Build #59

See Changes: -- [...truncated 500.76 KB...] Copy files Select CONFIG_HOST_LINUX=y Refreshing... Building NuttX... --

Re: NuttX github action pull request check build CI enabled

I had been confused earlier and thought that we were talking about the buildroot repo. The NuttX buildroot only shares the name with the "real" buildroot because it leveraged from it.  It is a completely incompatible, unrelated thing now (but still have the roots and the name).

Re: NuttX github action pull request check build CI enabled

On Mon, Mar 9, 2020 at 5:37 PM Gregory Nutt wrote: > On 3/9/2020 3:33 PM, Gregory Nutt wrote: > I understand that there have been exceptions made for Apache > projects to > allow GPL support tools into Apache project. I would not have any > difficulty granting those repositori

Re: NuttX github action pull request check build CI enabled

On 3/9/2020 3:33 PM, Gregory Nutt wrote: I understand that there have been exceptions made for Apache projects to allow GPL support tools into Apache project.  I would not have any difficulty granting those repositories to the project.  But I cannot comfortably use the github NuttX repositor

Re: NuttX github action pull request check build CI enabled

I understand that there have been exceptions made for Apache projects to allow GPL support tools into Apache project.  I would not have any difficulty granting those repositories to the project.  But I cannot comfortably use the github NuttX repository. The GPL projects no longer exist.  I

Re: NuttX github action pull request check build CI enabled

I understand that there have been exceptions made for Apache projects to allow GPL support tools into Apache project. I would not have any difficulty granting those repositories to the project. But I cannot comfortably use the github NuttX repository. The GPL projects no longer exist.  I ke

Re: NuttX github action pull request check build CI enabled

On Mon, Mar 9, 2020 at 5:00 PM Gregory Nutt wrote: > >> Should (or shouldn't) this become an official part of the Apache NuttX > >> project? I don't think anything stops anyone from hosting a mirror > >> anywhere they wish. > > > > It can't because it contains GPL code. My concern is that with no

Re: NuttX github action pull request check build CI enabled

Should (or shouldn't) this become an official part of the Apache NuttX project? I don't think anything stops anyone from hosting a mirror anywhere they wish. It can't because it contains GPL code. My concern is that with no project organization to manage it, I do not want to put the master i

Re: NuttX github action pull request check build CI enabled

Should (or shouldn't) this become an official part of the Apache NuttX project? I don't think anything stops anyone from hosting a mirror anywhere they wish. It can't because it contains GPL code. My concern is that with no project organization to manage it, I do not want to put the master i

Re: NuttX github action pull request check build CI enabled

On Sun, Mar 8, 2020 at 10:54 AM Gregory Nutt wrote: > >> I maintain only the Bitbucket tool repository. > >> > > Greg, can we migrate the bitucket tool to https://github.com/nuttx? > > No, I am going to keep my repositories on Bitbucket. Should (or shouldn't) this become an official part of the A

Re: squashing commits or not

On Sun, Mar 8, 2020 at 5:43 PM Gregory Nutt wrote: > Only slightly related... This morning, I removed some of the writing > instructions from the trop draft work flow proposal. I think they have > served their purpose and destroy readability of the document. I also > delete all of the comments t

Re: Should we relax precheck a little bit?

- Fixing the entire file we touch helps makes things better overall even though its painful in the short run. - Having a tool that produces accurate style recommendations is very important— it's hard to know what to fix and what not to fix if the tool doesn't give accurate me

Re: Should we relax precheck a little bit?

Having gone through a cycle of fixing a medium-sized PR recently, here are my thoughts: - Fixing the entire file we touch helps makes things better overall even though its painful in the short run. - Having a tool that produces accurate style recommendations is very important— it's har

Re: Should we relax precheck a little bit?

Yes, that is why I send this email to get the community feedback. To avoid the topic extend to the unrelated field, let's just focus on one thing I suggest: The github action just check the coding style for the modified lines in the patch, not the whole source lines. I am in favor of keeping

Re: Should we relax precheck a little bit?

How much time should we wait before starting a vote? When you know the vote will be in favour of your position is the time to call a vote. Actually in favour is probably too strong a position to take, it’s more that no-one would be against this course of action even if they may 100% agree w

RE: Should we relax precheck a little bit?

I agree with Alin. -1 -Original Message- From: Alin Jerpelea [mailto:jerpe...@gmail.com] Sent: Monday, March 09, 2020 5:36 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? -1 I thin that as a long term goal we should aim to have it enabled and leave each con

Re: Should we relax precheck a little bit?

-1 I thin that as a long term goal we should aim to have it enabled and leave each contributor to fix the styles as commits come in This way we will gradually have all violations fixed Alin On Mon, Mar 9, 2020 at 1:22 PM Justin Mclean wrote: > Hi, > > Sorry late here - what I should have said i

Re: Should we relax precheck a little bit?

Hi, Sorry late here - what I should have said is “may NOT 100% agree with it.”. Justin

Re: Should we relax precheck a little bit?

Hi, > How much time should we wait before starting a vote? When you know the vote will be in favour of your position is the time to call a vote. Actually in favour is probably too strong a position to take, it’s more that no-one would be against this course of action even if they may 100% agree

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 9:30 AM Gregory Nutt wrote: > > > > Since there's no current maintainer for nxstyle... What would people think > > about trying Clang-Format ? > > > > It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and > > Microso