Re: Question of PR Etiquette

On Sun, Mar 15, 2020 at 12:59 AM Justin Mclean wrote: > Hi, > > > Yes, this is last resort. It's better to discuss PR in the github and > > let the contributor fix the problem by self. The collaboration model > > can decrease the divergence and improve the community health. > > In my experience t

Re: pthread_mutex_lock() and signals

On Fri, Mar 13, 2020 at 6:53 PM Gregory Nutt wrote: > Nathan, > > There is one issue we have to be careful about: pthread > _mutex_timedlock(): It needs the signal in order to wake up and return > from the wait. pthread_mutex_lock() just calls pthread_mutex_timedlock() > with and time value of

Build failed in Jenkins: NuttX-Nightly-Build #64

See Changes: -- [...truncated 502.41 KB...] Copy files Select CONFIG_HOST_LINUX=y Refreshing... Building NuttX... --

Re: Question of PR Etiquette

Hi, > Yes, this is last resort. It's better to discuss PR in the github and > let the contributor fix the problem by self. The collaboration model > can decrease the divergence and improve the community health. In my experience this has the opposite effect, it discourages newcomers from contribu

Re: Question of PR Etiquette

On Sun, Mar 15, 2020 at 5:31 AM Gregory Nutt wrote: > > Question: Github permits committer to modify the content of > contributors PRs through this mechanism: > https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a

Question of PR Etiquette

Question:  Github permits committer to modify the content of contributors PRs through this mechanism: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork I appreciate that this may be expeditious, but it f

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

I looked at the clang-format source code. It has trouble aligning the = of a -= or +=. I easily made a change to align on the - or + of a -= or +=, but some work will be necessary to give an option that aligns the way the nuttx code does it. Will think more about it. -adam On Sat, Mar 14, 2020 a

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

David, Maciej, Peter, Thanks for your help! IndentPPDirectives: PPDIS_AfterHash works. The actual syntax for the .clang-format file is this: IndentPPDirectives: AfterHash That makes things a lot better. There are a bunch of inconsistent macro indents under sched/ though— many macros indent ok,

Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Adam and Maciej, Thank you for spending you time on this. It will be a huge win for everyone! The way I have been looking at this is like in transfer-function with an offset. Once we can get a tools that will take X and make into X" that has well known malformations. We just fix the malformati