RE: [DISCUSS] requirements for commit messages and PRs

2020-06-05 Thread David Sidrane
I think there are may more aspect than just the release notes. Yes we can ask every time for information but that is not a good use of everyone's time. Let the template ask for it. At the time the PR comes in, the submitter is the "expert in the problem domain". Not the committer. The

Re: [DISCUSS] requirements for commit messages and PRs

2020-06-05 Thread Nathan Hartman
On Thu, Jun 4, 2020 at 7:19 PM Jukka Laitinen wrote: > But the template in the commit... please, no. I have had enough of those > in big companies and in the end they are just harmful. I agree with that!! We should not be too rigid and complicated. The more I think about it, the more I like

RE: dirname_r?

2020-06-05 Thread Xiang Xiao
Many other similar extension(e.g. strtok_r) become standard(POSIX), it's reasonable practice for other functions. > -Original Message- > From: Takashi Yamamoto > Sent: Friday, June 5, 2020 1:21 PM > To: dev@nuttx.apache.org > Subject: dirname_r? > > hi, > > i'm using FLAT memory