[DISCUSS] Wrapping up the Workflow document

2020-01-24 Thread Nathan Hartman
Hi all, The proposed Workflow document (see [1]) has a substantial amount of good information in it. It is not yet 100% percent complete: (1) There are several "REVISIT" notes throughout. (2) A few sections toward the end aren't written yet. However, by the 80-20 rule, I think the most important

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Miguel Ángel Herranz
Hi Nathan, I reviewed the document and added some inlines comments (not sure if they are not recommended for use though). I haven't edited/added any text though, but I will be glad to help if needed. Cheers, Miguel On Fri, Jan 24, 2020 at 4:29 PM Nathan Hartman wrote: > Hi all, > > The propos

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Gregory Nutt
I reviewed the document and added some inlines comments (not sure if they are not recommended for use though). I haven't edited/added any text though, but I will be glad to help if needed. We need to get you on the PPMC where it would be easier for you to make contributions 😀

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Nathan Hartman
On Tue, Jan 28, 2020 at 11:49 AM Miguel Ángel Herranz wrote: > Hi Nathan, > > I reviewed the document and added some inlines comments (not sure if they > are not recommended for use though). > > I haven't edited/added any text though, but I will be glad to help if > needed. Hello Miguel, Thank

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread David Sidrane
m.INVALID] Sent: Tuesday, January 28, 2020 8:49 AM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow document Hi Nathan, I reviewed the document and added some inlines comments (not sure if they are not recommended for use though). I haven't edited/added any text tho

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Abdelatif Guettouche
(no question > what you get) > > git checkout master_my_branch > git -b checkout master_my_branch_PR && git checkout master_my_branch > git reset --hard > git log master --oneline > ^C > git cherry-pick .. > > add -e to change the commit message i.e add [BA

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread David Sidrane
r a fetch. Then as you say, I rebase my wip on it. -Original Message- From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] Sent: Tuesday, January 28, 2020 2:17 PM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow document Hi David, Are you assuming that

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Abdelatif Guettouche
sult in a fast forward - with > many remotes I use git reset --hard /master after a fetch. > Then as you say, I rebase my wip on it. > > -Original Message- > From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] > Sent: Tuesday, January 28, 2020 2:17 PM > To:

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread David Sidrane
ote. David -Original Message- From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] Sent: Tuesday, January 28, 2020 5:04 PM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow document Hi David, In the workflow, deleting the branch is only suggested _after_

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Abdelatif Guettouche
nal Message- > From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] > Sent: Tuesday, January 28, 2020 5:04 PM > To: dev@nuttx.apache.org > Subject: Re: [DISCUSS] Wrapping up the Workflow document > > Hi David, > > In the workflow, deleting the branch is only suggested _after_

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread David Sidrane
he wrong remote. > > > > David > > > > -Original Message- > > From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] > > Sent: Tuesday, January 28, 2020 5:04 PM > > To: dev@nuttx.apache.org > > Subject: Re: [DISCUSS] Wrapping up the Workflo

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-28 Thread Abdelatif Guettouche
rong remote. > > > > > > David > > > > > > -Original Message- > > > From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] > > > Sent: Tuesday, January 28, 2020 5:04 PM > > > To: dev@nuttx.apache.org >

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread David Sidrane
add a section to the document tips and tricks and share these? Thanks for sharing! David -Original Message- From: Abdelatif Guettouche [mailto:abdelatif.guettou...@gmail.com] Sent: Tuesday, January 28, 2020 4:50 PM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow docume

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread Nathan Hartman
On Wed, Jan 29, 2020 at 8:10 AM David Sidrane wrote: > Good tips! git is s powerful it is nice to lean other's tricks. > > Here is my `gitlast` command (it helps me answer the question: What was I > doing?) > > git for-each-ref --count=30 --sort=-committerdate > refs/heads/ --format='%(refnam

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread David Sidrane
esday, January 29, 2020 6:47 AM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow document On Wed, Jan 29, 2020 at 8:10 AM David Sidrane wrote: > Good tips! git is s powerful it is nice to lean other's tricks. > > Here is my `gitlast` command (it helps me

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread Nathan Hartman
On Wed, Jan 29, 2020 at 10:14 AM David Sidrane wrote: > My general comment on the Workflow document is it is too much information > and comments. > > Perhaps it can be broken into patch Workflow, git Workflow and githup > Workflow and then just list the steps. > (Think in terms of a quckstart guid

RE: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread David Sidrane
, January 29, 2020 11:03 AM To: dev@nuttx.apache.org Subject: Re: [DISCUSS] Wrapping up the Workflow document On Wed, Jan 29, 2020 at 10:14 AM David Sidrane wrote: > My general comment on the Workflow document is it is too much information > and comments. > > Perhaps it can be broken into pa

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-29 Thread Abdelatif Guettouche
> From: Nathan Hartman [mailto:hartman.nat...@gmail.com] > Sent: Wednesday, January 29, 2020 11:03 AM > To: dev@nuttx.apache.org > Subject: Re: [DISCUSS] Wrapping up the Workflow document > > On Wed, Jan 29, 2020 at 10:14 AM David Sidrane > wrote: > > My general comme

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-30 Thread Miguel Ángel Herranz
On Tue, Jan 28, 2020 at 5:52 PM Gregory Nutt wrote: > We need to get you on the PPMC where it would be easier for you to make > contributions 😀 > Thanks, let's see :) I think for now is ok without becoming PPMC, but anyway I have sent the ICLA in case it could help to contribute in more areas.

Re: [DISCUSS] Wrapping up the Workflow document

2020-01-30 Thread Miguel Ángel Herranz
On Tue, Jan 28, 2020 at 6:01 PM Nathan Hartman wrote: ... > Please, feel free to improve the text. (Let us know if you need someone to > set up Confluence editing access for you.) > > Thank you very much, > Nathan > My pleasure. I have been busy the last couple of days, but I will try to help co