Re: RFC: do not copy const variables to RAM in AVR

2025-07-09 Thread kr . git
On 2025-07-09 01:20, Tomek CEDRO wrote: Thank you Kerogit :-) How about ARCH_HAVE_AVR_FLMAP? This would align with existing nomenclature and enable easy filtering / sorting? Thanks :-) Tomek Xiaoxiang781216 was faster on GitHub so I will be echoing a bit - I don't think ARCH_HAVE is a good

Re: RFC: do not copy const variables to RAM in AVR

2025-07-08 Thread Alin Jerpelea
Hi KR, thanks for sending a new patch series. The latest patches have been uploaded for review Best regards Alin On Wed, Jul 9, 2025 at 1:20 AM Tomek CEDRO wrote: > Thank you Kerogit :-) > > How about ARCH_HAVE_AVR_FLMAP? This would align with existing > nomenclature and enable easy filtering

Re: RFC: do not copy const variables to RAM in AVR

2025-07-08 Thread Tomek CEDRO
Thank you Kerogit :-) How about ARCH_HAVE_AVR_FLMAP? This would align with existing nomenclature and enable easy filtering / sorting? Thanks :-) Tomek On Tue, Jul 8, 2025 at 11:29 PM wrote: > > Hello, > > I prepared new version of the series, it's available in branch named > avrdx_flmap_v2 (and

Re: RFC: do not copy const variables to RAM in AVR

2025-07-08 Thread kr . git
Hello, I prepared new version of the series, it's available in branch named avrdx_flmap_v2 (and also attached.) The changes are based on the feedback both from the mailing list and from PR: 1) the #endif alignment was fixed. Checkpatch doesn't complain about assembly files unfortunately an

Re: RFC: do not copy const variables to RAM in AVR

2025-07-07 Thread kr . git
Hi, the naming may need to change but otherwise, this is intended. The main deciding factor for this change is always board's linker script - it has a final say for data placement and if it places .rodata into appropriate location in flash and makes sure pointers are adjusted to point into co

Re: RFC: do not copy const variables to RAM in AVR

2025-07-07 Thread kr . git
On 2025-07-07 13:03, Alin Jerpelea wrote: Hi KR, the patches have been submitted to mainline you can follow the feedback on https://github.com/apache/nuttx/pull/16687 Best regards Alin Thanks, will do.

Re: RFC: do not copy const variables to RAM in AVR

2025-07-07 Thread Alan C. Assis
Nice work KR and great Documentation! Kudos BTW, I added a comment about using AVR_BOARD_HAS_FLMAP vs ARCH_HAVE_FLMAP. BR, Alan On Mon, Jul 7, 2025 at 7:23 AM wrote: > Hello, > > I would like to submit patches which change handling of const variables > in AVR architecture, DA/DB family. > > A

Re: RFC: do not copy const variables to RAM in AVR

2025-07-07 Thread Alin Jerpelea
Hi KR, the patches have been submitted to mainline you can follow the feedback on https://github.com/apache/nuttx/pull/16687 Best regards Alin On Mon, Jul 7, 2025 at 12:23 PM wrote: > Hello, > > I would like to submit patches which change handling of const variables > in AVR architecture, DA

RFC: do not copy const variables to RAM in AVR

2025-07-07 Thread kr . git
Hello, I would like to submit patches which change handling of const variables in AVR architecture, DA/DB family. AVR is a Harvard architecture with separate address spaces for program and data memory. Unless the compiler is instructed otherwise, C pointers are always referring to the data m