Re: committing to the branch...

2007-04-24 Thread Jonathon -- Improov
Ray, A bugfix is a bugfix, whether or not it fixes bugs more than it causes harm. Commit the bugfix in the release branch, so those of us using the release branch can use your bugfix and alert you if it does cause harm. A bad bugfix will be quickly corrected soon after. As long as we're stric

[jira] Commented: (OFBIZ-926) product reviews counts cancelled reviews

2007-04-24 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491500 ] Scott Gray commented on OFBIZ-926: -- Hi Si I can't see the behaviour you've mentioned, I assume by cancelled you mean

[jira] Created: (OFBIZ-926) product reviews counts cancelled reviews

2007-04-24 Thread Si Chen (JIRA)
product reviews counts cancelled reviews Key: OFBIZ-926 URL: https://issues.apache.org/jira/browse/OFBIZ-926 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: ecomme

[jira] Created: (OFBIZ-925) Duplicate entry for key 1) on login

2007-04-24 Thread Krzysztof Podejma (JIRA)
Duplicate entry for key 1) on login --- Key: OFBIZ-925 URL: https://issues.apache.org/jira/browse/OFBIZ-925 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: framework Af

Re: committing to the branch...

2007-04-24 Thread David E. Jones
Ray, You're absolutely correct that we should be applying patches as much as we can and have time for to the release branch to fix bugs there as well. I just updated the permissions so you should now be able to do this. -David On Apr 24, 2007, at 12:52 PM, Ray Barlow wrote: Personally

[jira] Commented: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491430 ] Adrian Crum commented on OFBIZ-911: --- Jacques, Are you sure you uploaded the correct gif files? The latest zip conta

[jira] Closed: (OFBIZ-924) Add a financial account summary section to the view profile page

2007-04-24 Thread Andrew Zeneski (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Zeneski closed OFBIZ-924. Resolution: Fixed Checked into SVN > Add a financial account summary section to the view profile pa

[jira] Updated: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-911: -- Attachment: main_nav.zip Last main_nav.zip contains transparent background (white on white) > I

[jira] Updated: (OFBIZ-924) Add a financial account summary section to the view profile page

2007-04-24 Thread Joe Eckard (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-924: - Attachment: fa-patch-correct-paths.txt > Add a financial account summary section to the view profile page

[jira] Updated: (OFBIZ-924) Add a financial account summary section to the view profile page

2007-04-24 Thread Joe Eckard (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-924: - Attachment: FinAccountDetail.ftl > Add a financial account summary section to the view profile page >

[jira] Updated: (OFBIZ-924) Add a financial account summary section to the view profile page

2007-04-24 Thread Joe Eckard (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-924: - Attachment: fa-patch.txt > Add a financial account summary section to the view profile page >

[jira] Created: (OFBIZ-924) Add a financial account summary section to the view profile page

2007-04-24 Thread Joe Eckard (JIRA)
Add a financial account summary section to the view profile page Key: OFBIZ-924 URL: https://issues.apache.org/jira/browse/OFBIZ-924 Project: OFBiz (The Open for Business Project)

Re: committing to the branch...

2007-04-24 Thread Ray Barlow
Personally I was expecting to contribute fixes to the branch as well even if I generally work on and use the trunk. At this point in time merging the fix I've done into the branch requires little to no extra effort as I can safely say if it works in the trunk it will work in the branch as they are

Re: committing to the branch...

2007-04-24 Thread BJ Freeman
from http://docs.ofbiz.org/display/OFBADMIN/Release+Plan Steps for applying a fix from the trunk to a branch as part of maintenance: seems to put that responsibility on those that have checked out the branch. Ray Barlow sent the following on 4/24/2007 8:05 AM: > I have just applied this fix to t

[jira] Commented: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491379 ] Jacques Le Roux commented on OFBIZ-911: --- Actually you are right Adrian, not sure they are better. Strange things

[jira] Commented: (OFBIZ-742) NullPointerException inside SqlJdbcUtil.java

2007-04-24 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491367 ] Jacopo Cappellato commented on OFBIZ-742: - You are right Michael, sorry. I was just confused by the following

committing to the branch...

2007-04-24 Thread Ray Barlow
I have just applied this fix to the trunk, is the general process that I can apply it to the branch 4.0 release because it's a small bug fix or do we want a cool off period to allow others to review and test so as to reduce the risk of adverse effects getting it to the "stable" branch? Ray [EMAI

[jira] Commented: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491343 ] Jacques Le Roux commented on OFBIZ-911: --- No problem Adrian, I will do it tonight. > Improved style for main nav

[jira] Commented: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491319 ] Adrian Crum commented on OFBIZ-911: --- Jacques, If it's not too much trouble, could you change the white background t

Re: Post Branch Enhancements

2007-04-24 Thread Jonathon -- Improov
Jacques, Yes, that seems to be the best way. Only I don't have time to even do the Jira issues (I'd have to split up my enhancements neatly). But don't worry. My stuff is always kept in step (playing well) with the latest OFBiz trunk revision. It wouldn't be difficult to reconcile my stuff in

Re: Post Branch Enhancements

2007-04-24 Thread Jonathon -- Improov
Jacques, Yes, that seems to be the best way. Only I don't have time to even do the Jira issues (I'd have to split up my enhancements neatly). But don't worry. My stuff is always kept in step (playing well) with the latest OFBiz trunk revision. It wouldn't be difficult to reconcile my stuff in

[jira] Closed: (OFBIZ-923) Product reviews not visible

2007-04-24 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray closed OFBIZ-923. Resolution: Invalid Hi Arno Reviews have to be approved in the product manager before they are displayed in

[jira] Commented: (OFBIZ-742) NullPointerException inside SqlJdbcUtil.java

2007-04-24 Thread Michael Imhof (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491244 ] Michael Imhof commented on OFBIZ-742: - Why would you like to close this issue? The bug isn't fixed yet... > NullP

[jira] Created: (OFBIZ-923) Product reviews not visible

2007-04-24 Thread Arno Peters (JIRA)
Product reviews not visible --- Key: OFBIZ-923 URL: https://issues.apache.org/jira/browse/OFBIZ-923 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: ecommerce Affects Versions:

[jira] Updated: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-911: -- Attachment: main_nav.zip main_nav.zip contains gif files for main nav tab bar. Gif files go in framewor

[jira] Reopened: (OFBIZ-911) Improved style for main navigation bar

2007-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reopened OFBIZ-911: --- New styles. Let's try this again. > Improved style for main navigation bar >

[jira] Created: (OFBIZ-922) Viewing profile in ecommerce shows error: missing MimeType

2007-04-24 Thread Arno Peters (JIRA)
Viewing profile in ecommerce shows error: missing MimeType -- Key: OFBIZ-922 URL: https://issues.apache.org/jira/browse/OFBIZ-922 Project: OFBiz (The Open for Business Project) Issue Ty

[jira] Commented: (OFBIZ-918) New Styles For Back Office Apps

2007-04-24 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491208 ] Jacopo Cappellato commented on OFBIZ-918: - ah ah, thanks Chris/Adrian!!! Now I understand. Jacopo > New St

[jira] Commented: (OFBIZ-918) New Styles For Back Office Apps

2007-04-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491206 ] Adrian Crum commented on OFBIZ-918: --- Jacopo, Tom Foolery isn't a person and there are no licensing issues. "Tom Foo

[jira] Commented: (OFBIZ-918) New Styles For Back Office Apps

2007-04-24 Thread Chris Howe (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491204 ] Chris Howe commented on OFBIZ-918: -- http://www.thefreedictionary.com/tomfoolery > New Styles For Back Office Apps >

[jira] Commented: (OFBIZ-918) New Styles For Back Office Apps

2007-04-24 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491202 ] Jacopo Cappellato commented on OFBIZ-918: - Adrian, who is Tom-Foolery ? Should we look for license issues on

[jira] Created: (OFBIZ-921) Spelling error on OFBiz web home page

2007-04-24 Thread David McNeill (JIRA)
Spelling error on OFBiz web home page - Key: OFBIZ-921 URL: https://issues.apache.org/jira/browse/OFBIZ-921 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: site Aff

Re: AW: Ofbiz Contribution Proposal

2007-04-24 Thread David E. Jones
I agree with Chris here. This can happen in many steps, and the first step doesn't have to be totally ready to go. It's perfectly fine to submit stuff knowing (and saying) that it's based on an older version or incomplete or in whatever way not totally ready to go. Whatever the case, wi

Re: AW: Ofbiz Contribution Proposal

2007-04-24 Thread Chris Howe
Hi Karl, I suspect there will be a lot of interest in what you're proposing. A bit more than the average "hey, I have an idea" Jira issue. In addition, most of what you described in your proposal appears rather modular to the current code. If I were in your position, I would open a Jira issue

Re: Post Branch Enhancements

2007-04-24 Thread Jacques Le Roux
Jonathon, I thought about all that and at this point I believe, regarding licence issues, the only way is for you 1. to create Jira issues for your own proper additions/modifications (being careful to don't mix "joint work", and checking ASL granted of course) 2. to comment in existing Jira issue