Re: svn commit: r544640 - in /ofbiz/trunk/framework/entity: config/entityengine.xml dtd/entity-config.xsd src/org/ofbiz/entity/config/DatasourceInfo.java src/org/ofbiz/entity/jdbc/DatabaseUtil.java

2007-06-06 Thread Scott Gray
Hi David Does this belong in the release branch as well? I don't mind doing it, I'm just not sure without looking deeper and I thought you might know off hand. Thanks Scott On 06/06/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: jonesde Date: Tue Jun 5 14:24:21 2007 New Revision:

Re: svn commit: r541349 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

2007-06-06 Thread Jacopo Cappellato
Scott, that is part of the refactoring of the processes related to billing accounts, that I have completed in the weekend (but needs more tests). That was a refactoring and a bug fix in the same time (that resolved several bugs reported in Jira); in fact the previous implementation of the

[jira] Commented: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501846 ] nicolas malin commented on OFBIZ-1066: -- Hi Andrew, Your patch is rejected in my ofbiz environment. Do you

[jira] Updated: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-1066: - Attachment: PaymentGatewayServices.java BigDecimal to Double precision problem in

[jira] Updated: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-1066: - Attachment: PaymentGatewayServices-ofbiz.java.patch BigDecimal to Double precision problem in

Re: svn commit: r541349 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

2007-06-06 Thread Jacques Le Roux
Scott, Jacopo, I noticed 2 other related trunk commits about that point (if I'm not wrong, really in a hurry) 544091 and 543271 Thanks to both of you ! Jacques - Message d'origine - De : Jacopo Cappellato [EMAIL PROTECTED] À : dev@ofbiz.apache.org Envoyé : mercredi 6 juin 2007 10:10

Re: svn commit: r541349 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

2007-06-06 Thread Scott Gray
I put rev. 52 in because it was a simple check for null on paymentPrefs. While my knowledge of the billing account code is pretty limited, I think that billing accounts have been pretty throughly implemented in OFBiz to the point that the refactor is really just a big bugfix for all the

[jira] Updated: (OFBIZ-1046) Migration of some old ftl/bsh files for the product screens to the widgets

2007-06-06 Thread Mario Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Cappellato updated OFBIZ-1046: Attachment: product.patch convertion of productKeyword and GoodIdentification screens and

[jira] Commented: (OFBIZ-1046) Migration of some old ftl/bsh files for the product screens to the widgets

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501865 ] Jacopo Cappellato commented on OFBIZ-1046: -- Thanks, rev. 544778 Migration of some old ftl/bsh files for

[jira] Assigned: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-1066: Assignee: Jacopo Cappellato BigDecimal to Double precision problem in

[jira] Assigned: (OFBIZ-1046) Migration of some old ftl/bsh files for the product screens to the widgets

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-1046: Assignee: Jacopo Cappellato Migration of some old ftl/bsh files for the product

[jira] Closed: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-1066. Resolution: Fixed Nicolas, thanks for the patch; it is in rev. 544783 Andrew, I think that

[jira] Assigned: (OFBIZ-1064) Language select box of the ecommerce is wrong size (Firefox IE6)

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-1064: Assignee: Jacopo Cappellato Language select box of the ecommerce is wrong size

[jira] Commented: (OFBIZ-1060) createInvoiceForOrder ECA not being called

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501888 ] Jacopo Cappellato commented on OFBIZ-1060: -- I've reviewed the patch and I agree with Andrew. Is there a

[jira] Closed: (OFBIZ-1063) Simplify Outermost HTML Containers, Part 2

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-1063. Resolution: Fixed Thanks Adrian, your patch is in rev. 544794 Simplify Outermost HTML

[jira] Closed: (OFBIZ-1064) Language select box of the ecommerce is wrong size (Firefox IE6)

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-1064. Resolution: Fixed Oleg, Adrian, thanks. Oleg patch is in rev. 544790 Language select

[jira] Assigned: (OFBIZ-1063) Simplify Outermost HTML Containers, Part 2

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-1063: Assignee: Jacopo Cappellato Simplify Outermost HTML Containers, Part 2

[jira] Commented: (OFBIZ-1054) Filtering expired emails in sendEmailToContactList method

2007-06-06 Thread Ray Barlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501886 ] Ray Barlow commented on OFBIZ-1054: --- I've not tested so not committed, but the patch looks OK. It did lead me to

Re: svn commit: r541349 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

2007-06-06 Thread Jacques Le Roux
+1 for sit and wait some time Jacques I put rev. 52 in because it was a simple check for null on paymentPrefs. While my knowledge of the billing account code is pretty limited, I think that billing accounts have been pretty throughly implemented in OFBiz to the point that the refactor

[jira] Commented: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread Andrew Sykes (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501918 ] Andrew Sykes commented on OFBIZ-1066: - Jacopo, Yes, my patch was a real mess, I made it on a recent revision

[jira] Commented: (OFBIZ-1066) BigDecimal to Double precision problem in PaymentGatewayServices

2007-06-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501923 ] nicolas malin commented on OFBIZ-1066: -- It a pleasure for me ;) Thanks jacopo for commit it and thanks androw

SVN commit 544733

2007-06-06 Thread Adrian Crum
From commit log: Changes related to getting forum to work. [snip] This is all still rough. I will be trying to refine it in the near future. Al, I would like to help out with this. I'm wrapping up my calendar project and I want to work on forums next. I can lend you a hand in a few weeks or

Re: svn commit: r544640 - in /ofbiz/trunk/framework/entity: config/entityengine.xml dtd/entity-config.xsd src/org/ofbiz/entity/config/DatasourceInfo.java src/org/ofbiz/entity/jdbc/DatabaseUtil.java

2007-06-06 Thread David E Jones
I don't think this should go into the release branch, but this is a borderline case. It is a new feature that makes it easier to compensate for a problem with Derby unique indices while still leaving those working for other DBs. The motivation for this is a few new indexes that are not in the

[jira] Created: (OFBIZ-1067) Form Widget values are not always escaped for html special characters

2007-06-06 Thread Vinay Agarwal (JIRA)
Form Widget values are not always escaped for html special characters - Key: OFBIZ-1067 URL: https://issues.apache.org/jira/browse/OFBIZ-1067 Project: OFBiz Issue Type: Bug

[jira] Updated: (OFBIZ-1067) Form Widget values are not always escaped for html special characters

2007-06-06 Thread Vinay Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay Agarwal updated OFBIZ-1067: - Attachment: ofbizFormsHtmlEscape.patch Form Widget values are not always escaped for html

[jira] Commented: (OFBIZ-1067) Form Widget values are not always escaped for html special characters

2007-06-06 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501985 ] Jacopo Cappellato commented on OFBIZ-1067: -- +1 (not tested but sounds good). Form Widget values are not

Re: svn commit: r544640 - in /ofbiz/trunk/framework/entity: config/entityengine.xml dtd/entity-config.xsd src/org/ofbiz/entity/config/DatasourceInfo.java src/org/ofbiz/entity/jdbc/DatabaseUtil.java

2007-06-06 Thread Scott Gray
Great, thanks David On 07/06/07, David E Jones [EMAIL PROTECTED] wrote: I don't think this should go into the release branch, but this is a borderline case. It is a new feature that makes it easier to compensate for a problem with Derby unique indices while still leaving those working for

Re: Substring method for minilang?

2007-06-06 Thread Ean Schuessler
I realize that this isn't productive in any way... but... Minilang is the work of the Devil and I will do anything I can not to write code in it. Just thought I'd chime in. ;-) On Monday 04 June 2007 03:57:10 pm Al Byers wrote: I was aware of the call methods, but here is the code that I wrote

Re: Substring method for minilang?

2007-06-06 Thread Ean Schuessler
On Wednesday 06 June 2007 10:51:28 pm David E Jones wrote: Alternatively Ean, and maybe even better: in an ideal world what would you use in place of the MiniLang/simple-method code (regardless of whether or not it exists already)? As we've done in the past, if there is anything that

Re: Substring method for minilang?

2007-06-06 Thread Jonathon -- Improov
Minilang does just about everything I need for data operations (retrieval, update, creation, deletion). Via map-processors, there's even some decent ways to manipulate (pre-massage) the data for display or storage. About 99% of the backend codes deal with data operations like that. Minilang

Re: Substring method for minilang?

2007-06-06 Thread Jonathon -- Improov
Ean, A major part of the reason why Simple Methods can be difficult to read is this: you can't write reentrant functions in Minilang. Maybe repeated chunks of Minilang codes cannot be abstracted into neat reentrant functions. Once you introduce reentrant functions, you'll find Minilang just