[jira] Commented: (OFBIZ-2414) links not unique when the same screen containing the same form is used more than once.

2009-09-29 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760525#action_12760525 ] Hans Bakker commented on OFBIZ-2414: the same problem appears when a a form is iterated

[jira] Commented: (OFBIZ-2964) seleniumXml: Patch 1 to seleniumXml ofbiz integration

2009-09-29 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760538#action_12760538 ] Hans Bakker commented on OFBIZ-2964: Hi Brett. i have committed your patch in revision

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Ashish Vijaywargiya
Hello Hans, This is friendly reminder that your commit contains *tabs* once again. Can you please take care of it? Please let me community know about your editor settings so we can solve the problem and can come to some better solution. Thanks! - +if (UtilValidate.isNotEmpty(

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Hans Bakker
I am sorry, i have to remove them by hand and sometimes i forget some... On Tue, 2009-09-29 at 14:38 +0530, Ashish Vijaywargiya wrote: Hello Hans, This is friendly reminder that your commit contains *tabs* once again. Can you please take care of it? Please let me community know about

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Ashish Vijaywargiya
No problem Hans. Take your time and please let me know if I can be of help for you to solve this Tab issue. -- Ashish On Tue, Sep 29, 2009 at 2:42 PM, Hans Bakker mailingl...@antwebsystems.comwrote: I am sorry, i have to remove them by hand and sometimes i forget some... On Tue, 2009-09-29

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Jacques Le Roux
Hi Hans, Why not reverting to Ganymede and using AnyEdit for non Java and XML files ? Jacques From: Hans Bakker mailingl...@antwebsystems.com I am sorry, i have to remove them by hand and sometimes i forget some... On Tue, 2009-09-29 at 14:38 +0530, Ashish Vijaywargiya wrote: Hello Hans,

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Ashish Vijaywargiya
Another solution that you can use is described below. In your eclipse IDE go to: Window - Preferences - General - Text Editors - Enable Show whitespace character. For more details you can see the image attached at (Also refer how it shows tab in two other pictures):

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Hans Bakker
Thank you for your help Ashish. On Tue, 2009-09-29 at 15:22 +0530, Ashish Vijaywargiya wrote: Another solution that you can use is described below. In your eclipse IDE go to: Window - Preferences - General - Text Editors - Enable Show whitespace character. For more details you can see the

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Ashish Vijaywargiya
Not a problem Hans. Have a nice day ahead :-). -- Regards Ashish Vijaywargiya HotWax Media Pvt. Ltd. http://www.hotwaxmedia.com Helping hand around the World ... USA | Italy | New Zealand | India Hans Bakker wrote: Thank you for your help Ashish. On Tue, 2009-09-29 at 15:22 +0530, Ashish

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Jacques Le Roux
Yes there is even the same in AnyEDit (FTL, etc.) Menu Edit/Show Withespace. It's a bit differrent : not showing points but coloring in light green. Not that it works also from the toolbar with a click. You may have the same (toolbar) for Eclipse integrated editor : Menu Windows/Customoize

[jira] Updated: (OFBIZ-2957) HR Clearance Functionality

2009-09-29 Thread Richa Mittal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richa Mittal updated OFBIZ-2957: Attachment: Clearance_HR.patch Hi This is an improved patch incorporated with the suggested

Re: svn commit: r819849 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: WidgetWorker.java screen/IterateSectionWidget.java

2009-09-29 Thread Ashish Vijaywargiya
Inline: -- Ashish On Tue, Sep 29, 2009 at 3:45 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Yes there is even the same in AnyEDit (FTL, etc.) Menu Edit/Show Withespace. It's a bit differrent : not showing points but coloring in light green. Not that it works also from the

Re: svn commit: r819845 - /ofbiz/trunk/framework/common/data/CommonTypeData.xml

2009-09-29 Thread Adrian Crum
Hans, The default theme is supposed to be defined in the database - that is part of the visual theme design. Please revert this commit. -Adrian hans...@apache.org wrote: Author: hansbak Date: Tue Sep 29 07:07:51 2009 New Revision: 819845 URL: http://svn.apache.org/viewvc?rev=819845view=rev

Re: svn commit: r819863 [1/2] - in /ofbiz/trunk/framework/testtools: ./ config/ src/org/ofbiz/testtools/ src/org/ofbiz/testtools/seleniumxml/ src/org/ofbiz/testtools/seleniumxml/util/ testdef/selenium

2009-09-29 Thread Adam Heath
hans...@apache.org wrote: Author: hansbak Date: Tue Sep 29 08:57:00 2009 New Revision: 819863 URL: http://svn.apache.org/viewvc?rev=819863view=rev Log: patch supplied in OFBIZ-2964 by Brett palmer What does this do? Don't force us to cross-reference the universe. You know what it does at

Re: svn commit: r818053 - in /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/profile: EditProfile.ftl ViewProfile.ftl

2009-09-29 Thread Adam Heath
m...@apache.org wrote: Author: mor Date: Wed Sep 23 11:05:57 2009 New Revision: 818053 URL: http://svn.apache.org/viewvc?rev=818053view=rev Log: Misc. improvements, patch from Bharat Soni. Bad description, at least try to describe what you are changing.

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread Adam Heath
lekt...@apache.org wrote: Author: lektran Date: Thu Sep 24 00:56:30 2009 New Revision: 818335 URL: http://svn.apache.org/viewvc?rev=818335view=rev Log: Misc. cleanups And those cleanups are?

Re: svn commit: r818500 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/string/UelUtil.java

2009-09-29 Thread Adam Heath
adri...@apache.org wrote: Author: adrianc Date: Thu Sep 24 14:52:40 2009 New Revision: 818500 URL: http://svn.apache.org/viewvc?rev=818500view=rev Log: UEL bug fix. Patch provided by Mridul Pathak - https://issues.apache.org/jira/browse/OFBIZ-2928. What is the bug that is being fixeD?

Re: svn commit: r818565 - in /ofbiz/trunk/specialpurpose/pos/screens/800x600/dialog: ./ error/

2009-09-29 Thread Adam Heath
jler...@apache.org wrote: Author: jleroux Date: Thu Sep 24 17:44:09 2009 New Revision: 818565 URL: http://svn.apache.org/viewvc?rev=818565view=rev Log: Complete previous commits for different screen sizes for POS with untouched files Which previous commit? Your last commit had nothing

Re: svn commit: r819067 [1/3] - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ entity/src/META-INF/services/ entity/src/org/ofbiz/entity/

2009-09-29 Thread Adam Heath
adri...@apache.org wrote: Author: adrianc Date: Fri Sep 25 23:36:13 2009 New Revision: 819067 URL: http://svn.apache.org/viewvc?rev=819067view=rev Log: Refactored GenericDelegator.java based on a design proposed by Adam Heath on the dev mailing list. DelegatorInterface.java has been

Re: svn commit: r819067 [1/3] - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ entity/src/META-INF/services/ entity/src/org/ofbiz/entity/

2009-09-29 Thread Adrian Crum
Adam, Thanks for the tips! The public modifier and @Deprecated in the Delegator interface are carried over from GenericDelegator.java. I used Eclipse to extract the interface - hence the public modifier. David Jones deprecated the methods - not me. We can remove the deprecated methods when

Re: svn commit: r819067 [1/3] - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ entity/src/META-INF/services/ entity/src/org/ofbiz/entity/

2009-09-29 Thread Adam Heath
Adrian Crum wrote: Adam, Thanks for the tips! The public modifier and @Deprecated in the Delegator interface are carried over from GenericDelegator.java. I used Eclipse to extract the interface - hence the public modifier. David Jones deprecated the methods - not me. We can remove the

Re: svn commit: r819067 [1/3] - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ entity/src/META-INF/services/ entity/src/org/ofbiz/entity/

2009-09-29 Thread Adrian Crum
I understand what you're suggesting. But if the intention is to replace GenericDelegator delegator = GenericDelegator.getDelegator(delegatorName); with Delegator delegator = (Delegator) UtilObject.getObjectFromFactory(DelegatorFactory.class, delegatorName); then the Delegator interface will

Re: svn commit: r819067 [1/3] - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/ entity/src/META-INF/services/ entity/src/org/ofbiz/entity/

2009-09-29 Thread Adam Heath
Adrian Crum wrote: I understand what you're suggesting. But if the intention is to replace GenericDelegator delegator = GenericDelegator.getDelegator(delegatorName); with Delegator delegator = (Delegator) UtilObject.getObjectFromFactory(DelegatorFactory.class, delegatorName); then

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread Scott Gray
Miscellaneous On 30/09/2009, at 5:51 AM, Adam Heath wrote: lekt...@apache.org wrote: Author: lektran Date: Thu Sep 24 00:56:30 2009 New Revision: 818335 URL: http://svn.apache.org/viewvc?rev=818335view=rev Log: Misc. cleanups And those cleanups are? smime.p7s Description: S/MIME

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread Adam Heath
A: Because it changes the flow of a conversion. Q: Why is top-posting frowned upon? Scott Gray wrote: Miscellaneous They aren't. * Access parameters thru the parameters map, instead of on the request object directly. * Use groovy empty object logic, instead of comparing values against an

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread Adrian Crum
A. Frowning upon top-posting. Q. What causes those deep creases in the forehead? Adam Heath wrote: A: Because it changes the flow of a conversion. Q: Why is top-posting frowned upon? Scott Gray wrote: Miscellaneous They aren't. * Access parameters thru the parameters map, instead of on

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread Scott Gray
Fair enough point taken, except for the top-posting thing. Regards Scott On 30/09/2009, at 10:02 AM, Adam Heath wrote: A: Because it changes the flow of a conversion. Q: Why is top-posting frowned upon? Scott Gray wrote: Miscellaneous They aren't. * Access parameters thru the parameters

Re: svn commit: r818335 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductContentContent.groovy

2009-09-29 Thread David E Jones
My opinion, for what it's worth: Top posting: IDC Commit comments: Adam's right, most of them are useless and might as well just say changed stuff all the time; I'm glad someone is complaining about this! -David On Sep 29, 2009, at 3:22 PM, Adrian Crum wrote: A. Frowning upon

[jira] Created: (OFBIZ-2977) Abilty to allow Product Store to indicate which credit card types they accept

2009-09-29 Thread Bob Morley (JIRA)
Abilty to allow Product Store to indicate which credit card types they accept - Key: OFBIZ-2977 URL: https://issues.apache.org/jira/browse/OFBIZ-2977 Project: OFBiz

[jira] Updated: (OFBIZ-2977) Abilty to allow Product Store to indicate which credit card types they accept

2009-09-29 Thread Bob Morley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bob Morley updated OFBIZ-2977: -- Attachment: OFBIZ-2977_ProductStoreCreditCardSettings.patch Majority of work is done here. The pieces

[jira] Commented: (OFBIZ-2977) Abilty to allow Product Store to indicate which credit card types they accept

2009-09-29 Thread Bob Morley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760731#action_12760731 ] Bob Morley commented on OFBIZ-2977: --- The biggest impact here is that credit cards have a

(long) Re: svn commit: r818335 - (changelog best practices)

2009-09-29 Thread Adam Heath
David E Jones wrote: My opinion, for what it's worth: Opinions: $5 Dirty Looks: Free Commit comments: Adam's right, most of them are useless and might as well just say changed stuff all the time; I'm glad someone is complaining about this! Examples of badness: -- * Fixed bug (reported

Re: svn commit: r819845 - /ofbiz/trunk/framework/common/data/CommonTypeData.xml

2009-09-29 Thread Hans Bakker
Ok Adrian your record is back, however can now be overridden by values in general properties: committed in R820178 On Tue, 2009-09-29 at 07:46 -0700, Adrian Crum wrote: Hans, The default theme is supposed to be defined in the database - that is part of the visual theme design. Please revert

Re: svn commit: r819863 [1/2] - in /ofbiz/trunk/framework/testtools: ./ config/ src/org/ofbiz/testtools/ src/org/ofbiz/testtools/seleniumxml/ src/org/ofbiz/testtools/seleniumxml/util/ testdef/selenium

2009-09-29 Thread Hans Bakker
Hi Adam, I committed this change for a number of reasons: 1. The subject of testing is relatively new but is essential for further development of the system: any progress especially from Brett is very much welcome. 2. It is complete separated in its own component and has no connections to other

Re: svn commit: r819845 - /ofbiz/trunk/framework/common/data/CommonTypeData.xml

2009-09-29 Thread Scott Gray
It would probably be better to have it the other way around i.e. general.properties containing the final fallback if the database record is missing. Regards Scott HotWax Media http://www.hotwaxmedia.com On 30/09/2009, at 6:17 PM, Hans Bakker wrote: Ok Adrian your record is back, however

Re: svn commit: r819277 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/cache/UtilCache.java common/data/CommonTypeData.xml common/data/GeoData_CN.xml

2009-09-29 Thread Deepak Dixit
Hi Jacques, I was looking at the data file and found that GeoData_CN.xml file is not getting loaded at the time of ant run-install. The reason behind this is there is no entry for this file in ofbiz-component.xml. Is this intended ? -- Thanks and Regards Deepak Dixit jler...@apache.org

Re: svn commit: r819845 - /ofbiz/trunk/framework/common/data/CommonTypeData.xml

2009-09-29 Thread Hans Bakker
That is difficult because this is only true for values within the GLOBAL_PREFERENCES group, and when this is missing in the database, the keyvalues are unknown.. Regards, Hans On Wed, 2009-09-30 at 18:24 +1300, Scott Gray wrote: It would probably be better to have it the other way around i.e.

Re: svn commit: r819845 - /ofbiz/trunk/framework/common/data/CommonTypeData.xml

2009-09-29 Thread Scott Gray
Stepping back a second, why do we need a setting in general.properties when we have a database setting as seed data? Regards Scott On 30/09/2009, at 6:38 PM, Hans Bakker wrote: That is difficult because this is only true for values within the GLOBAL_PREFERENCES group, and when this is