Re: Hippo CMS

2010-07-08 Thread Michael Xu (xudong)
hi Scott, Thanks. We are customizing ofbiz for a customer here in China. Party, Order, Agreement, AP/AR, Birt, Catalog are in the current scope and we feel very comfortable with the flexibility offered by ofbiz. Now customer needs CMS. However, current CMS component is not that ready in ofbiz.

Re: Adding agreementId to OrderHeader

2010-07-08 Thread Jacopo Cappellato
BJ, the existing data model (as it is described in the Data Model Resource Book as you have mentioned previously) already takes care of this and I am not planning to change this. My proposal was related to the agreements picked for an order. Jacopo On Jul 8, 2010, at 12:59 AM, BJ Freeman

Re: Adding agreementId to OrderHeader

2010-07-08 Thread Jacopo Cappellato
Scott, Adam, BJ, thanks for your feedback. Based on your comments we will probably need also an AgreementOrderApplPurpose (or Type) entity so that we could have an agreement that governs the terms and prices applied to a customer, the commissions due to a sales rep etc... (unless we just rely

Re: Hippo CMS

2010-07-08 Thread Scott Gray
Hi Michael, Personally, I wouldn't do anymore than the most basic CMS work with the existing OFBiz component, but maybe I'm biased because I want to see it replaced :-) In regards to working together, my spare time is pretty limited so I doubt that I'll be working very fast and probably

Re: Hippo CMS

2010-07-08 Thread Michael Xu (xudong)
hi Scott, Ok, no problem. Will discuss further internally first and then decide where to go ... -- Regards, Michael Xu (xudong) On Thu, Jul 8, 2010 at 3:04 PM, Scott Gray scott.g...@hotwaxmedia.comwrote: Hi Michael, Personally, I wouldn't do anymore than the most basic CMS work with the

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Scott Gray
The context setting should override the widget.properties setting, that is the only reason why we have a context version of the setting. Please respond to this one, you haven't responded to the discussion regarding your last commit yet. Regards Scott HotWax Media http://www.hotwaxmedia.com

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Hans Bakker
I agree with what the description of the code says at the top. your setting makes that the widget.verbose by default is false and the messages are not shown. Regards, Hans P.S. i missed the last comments, which one? On Thu, 2010-07-08 at 21:54 +1200, Scott Gray wrote: The context setting

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Hans Bakker
perhaps some more qualification: The context does override but only in the case when the properties file is false. On Thu, 2010-07-08 at 17:13 +0700, Hans Bakker wrote: I agree with what the description of the code says at the top. your setting makes that the widget.verbose by default is

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Scott Gray
Okay that should work, sorry, I only read the commit message but didn't go and look at the code. I think ideally the context setting would be null always unless an override should take place and in when it is set then the widget.properties setting should be ignored. But the situation you've

[jira] Created: (OFBIZ-3850) Exception on Add Credit Card page from Quick Checkout option

2010-07-08 Thread Mukesh Manohar Marathe (JIRA)
Exception on Add Credit Card page from Quick Checkout option - Key: OFBIZ-3850 URL: https://issues.apache.org/jira/browse/OFBIZ-3850 Project: OFBiz Issue Type: Bug

[jira] Updated: (OFBIZ-3850) Exception on Add Credit Card page from Quick Checkout option

2010-07-08 Thread Mukesh Manohar Marathe (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukesh Manohar Marathe updated OFBIZ-3850: -- Attachment: OFBIZ-3850.patch Here is the required patch for this issue.

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
Then you should change the description, not the code. The intended behavior is: The properties setting is the default, it can be overridden in the web.xml file (application-wide setting), or in the context (screen-specific setting). -Adrian --- On Thu, 7/8/10, Hans Bakker

Re: Hippo CMS

2010-07-08 Thread Adrian Crum
My spare time is very limited too, but I would be willing to help. -Adrian --- On Thu, 7/8/10, Scott Gray scott.g...@hotwaxmedia.com wrote: From: Scott Gray scott.g...@hotwaxmedia.com Subject: Re: Hippo CMS To: dev@ofbiz.apache.org Date: Thursday, July 8, 2010, 12:04 AM Hi Michael,

Re: Hippo CMS

2010-07-08 Thread Scott Gray
Okay well cool, I'll go ahead and create a branch at some point, I know Sascha has expressed interest as well so we may as well get the ball rolling. Regards Scott On 8/07/2010, at 11:54 PM, Adrian Crum wrote: My spare time is very limited too, but I would be willing to help. -Adrian

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Hans Bakker
please check the code before you comment? i changed it because the comments were not shown by default anymore as was originally. If you go that far , i will go so far and will use my veto and revert the code that added this context stuff? 'true' in the properties file should always show the

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
--- On Thu, 7/8/10, Hans Bakker mailingl...@antwebsystems.com wrote: please check the code before you comment? I did. i changed it because the comments were not shown by default anymore as was originally. Give an example please. As far as I can tell, the comments worked exactly as they

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Scott Gray
Hi Hans, Two points: 1. Calm down, this is just a discussion. Telling Adrian to look at the code is perfectly valid, getting mad and making threats is not 2. You're not the first to mention it but I don't know where this idea of a veto came from, it doesn't exist. When required, the PMC as

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-08 Thread Hans Bakker
Ok Scott asked me to reply. i do not have the time and even the knowledge to fix this. i opted to revert to 'double' here what was the quickest, however i agree not the perfect solution. Regards, Hans On Tue, 2010-07-06 at 20:37 +1200, Scott Gray wrote: If there is a risk of rounding errors

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-08 Thread BJ Freeman
please open a Jira with steps to create error. maybe someone that has time will fix it. so I suggest revert in svn change it in your local copy. Hans Bakker sent the following on 7/8/2010 5:28 AM: Ok Scott asked me to reply. i do not have the time and even the knowledge to fix this. i opted

Re: Adding agreementId to OrderHeader

2010-07-08 Thread BJ Freeman
Yes the datamodel that I referenced for partyrelationships is in Ofbiz. However there is no supporting code that creates a partyreleationship between the Company and Party with role of customer and partyrelationshiptype of Customer.(CUSTOMER_REL) So the queries I mentions will not return a list

QuickCreateCustomer

2010-07-08 Thread BJ Freeman
in testing my code from 9.04 to 10.4 I see createcustomer in the ecommerce has be replaced by QuickCreateCustomer. since the only difference is you can create a customer with just name. I would like to propose that it call a createCustomer after it created the entity. have the createCustomer

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Hans Bakker
Ok this is what happened: I upgraded ofbiz from about 3-4 weeks ago. Some time ago i created a new component in hot deploy using the web.xml from the example component. I see the widget comments are not generated. I check widget.properties and see the parameter is set to true. I used this feature

Re: QuickCreateCustomer

2010-07-08 Thread Hans Bakker
+1 On Thu, 2010-07-08 at 19:22 -0700, BJ Freeman wrote: in testing my code from 9.04 to 10.4 I see createcustomer in the ecommerce has be replaced by QuickCreateCustomer. since the only difference is you can create a customer with just name. I would like to propose that it call a

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
Hans, It's good that you took the time to understand the problem. What would be acceptable is to revert the changes you made so the original behavior is restored. Your first commit tried to fix something that wasn't broken, and your second commit disables a demonstration of how the widget

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Hans Bakker
Adrian, what i proposed to you was a compromise. You seem to only accept your way, as happened many times in the past. therefore i am not in for compromises any more. I would like you to remove the context code which enables the override in the web.xml. It makes the system unnecessarily

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
Hans, There was no need for a compromise because there was no problem to begin with. You just admitted the problem you were experiencing was due to a misconfiguration in your local copy. Your solution to that misconfiguration was to change the trunk. The trunk was not the problem - the problem

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread David E Jones
Adrian, I hate to say it, but it seems like these messages from Hans are presenting the issue and attempting to initiate a discussion on the best way to go forward, and your messages are not discussing the issue and instead appealing to some sort of reason to not change how things are at all.

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adam Heath
David E Jones wrote: Adrian, I hate to say it, but it seems like these messages from Hans are presenting the issue and attempting to initiate a discussion on the best way to go forward, and your messages are not discussing the issue and instead appealing to some sort of reason to not

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
David, You are missing the point - there was no issue. The code worked fine. I *have* addressed the issue. The correct behavior as designed was detailed in my first reply. If anyone needs further information they can check the commit logs and the related Jira issue. Hans had a misconfigured

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread Adrian Crum
--- On Thu, 7/8/10, Adam Heath doo...@brainfood.com wrote: David E Jones wrote: Adrian, I hate to say it, but it seems like these messages from Hans are presenting the issue and attempting to initiate a discussion on the best way to go forward, and your messages are not discussing the

Re: svn commit: r961684 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidget.java

2010-07-08 Thread David E Jones
Just because you are fine with how it works doesn't mean others are fine with it, which is usually the reason a discussion starts and discovering such differences and exploring possible resolutions is the point of discussions. For my part, getting back to the issue, I also noticed that the