Re: code simplification

2012-03-29 Thread Pierre Smits
Hi Erwan, Why this question? Shouldn't having made a JIRA issue for this not have been enough? It seems to me that starting a discussion for every piece of code here is overkill. Regards, Pierre Op 30 maart 2012 07:15 schreef Mansour Al Akeel het volgende: > For me, it makes happy when code ge

[jira] [Commented] (OFBIZ-4725) Currently the system ecommerce is B2C add functions to enable B2B

2012-03-29 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242099#comment-13242099 ] Pierre Smits commented on OFBIZ-4725: - I agree with Hans on this. A simple sanity chec

Re: code simplification

2012-03-29 Thread Mansour Al Akeel
For me, it makes happy when code get cleaned as we go. On Thu, Mar 29, 2012 at 4:55 PM, Erwan de FERRIERES wrote: > Hi, > > from ProductDisplayWorker.java, lines 171-176, there is an array used, which > contains only one value. Is it OK with you to remove this declaration and > simplify the cod

Re: svn commit: r1305898 - in /ofbiz/trunk/applications: order/webapp/ordermgr/order/ order/webapp/ordermgr/quote/ party/webapp/partymgr/WEB-INF/actions/party/ party/webapp/partymgr/party/contactmecht

2012-03-29 Thread Jacopo Cappellato
Hi Chatree, I am looking into this issue now (I will let you know soon); thank you for the bug report. Jacopo On Mar 30, 2012, at 5:51 AM, Chatree Srichart wrote: > Hi Jacopo > > I have a problem with this commit. > > On Tue, Mar 27, 2012 at 11:48 PM, wrote: > >> Author: jacopoc >> Date: T

Re: svn commit: r1305898 - in /ofbiz/trunk/applications: order/webapp/ordermgr/order/ order/webapp/ordermgr/quote/ party/webapp/partymgr/WEB-INF/actions/party/ party/webapp/partymgr/party/contactmecht

2012-03-29 Thread Chatree Srichart
Hi Jacopo I have a problem with this commit. On Tue, Mar 27, 2012 at 11:48 PM, wrote: > Author: jacopoc > Date: Tue Mar 27 16:48:54 2012 > New Revision: 1305898 > > URL: http://svn.apache.org/viewvc?rev=1305898&view=rev > Log: > OFBIZ-4715 Committed patch from Markus M. May to extend the countr

[jira] [Commented] (OFBIZ-4725) Currently the system ecommerce is B2C add functions to enable B2B

2012-03-29 Thread Hans Bakker (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242036#comment-13242036 ] Hans Bakker commented on OFBIZ-4725: Pre-register. most companies will only allow pre

code simplification

2012-03-29 Thread Erwan de FERRIERES
Hi, from ProductDisplayWorker.java, lines 171-176, there is an array used, which contains only one value. Is it OK with you to remove this declaration and simplify the code ? Regards, // get all order role entities for user by customer role type // final Stri

[jira] [Closed] (OFBIZ-4770) editCalEvent not use label system on status drop-down

2012-03-29 Thread Erwan de FERRIERES (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-4770. - Resolution: Fixed Fix Version/s: SVN trunk done at rev 1307097 Thanks Nicolas

Re: [jira] [Closed] (OFBIZ-3638) Assigning a resource to a task is not reflected in the resource's tasks view.

2012-03-29 Thread Pierre Smits
Hi Erwan, Thanks for correcting and committing the patch. My apologies for not removing the section out-of-date. Regards, Pierre Op 29 maart 2012 22:20 schreef Erwan de FERRIERES (Closed) (JIRA) < j...@apache.org> het volgende: > > [ > https://issues.apache.org/jira/browse/OFBIZ-3638?page=

[jira] [Closed] (OFBIZ-3638) Assigning a resource to a task is not reflected in the resource's tasks view.

2012-03-29 Thread Erwan de FERRIERES (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3638. - Resolution: Fixed Fix Version/s: SVN trunk Thanks Peter for reporting, and Pierre

[jira] [Issue Comment Edited] (OFBIZ-2366) Documents - Sales Force Automation component

2012-03-29 Thread Pierre Smits (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241595#comment-13241595 ] Pierre Smits edited comment on OFBIZ-2366 at 3/29/12 8:19 PM: --

[jira] [Commented] (OFBIZ-2366) Documents - Sales Force Automation component

2012-03-29 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241595#comment-13241595 ] Pierre Smits commented on OFBIZ-2366: - I propose that we close this issue if a descrip

[jira] [Commented] (OFBIZ-1645) Screens to manage Forecast in SFA webapp

2012-03-29 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241591#comment-13241591 ] Pierre Smits commented on OFBIZ-1645: - This issue can be set to closed as the forecast

[jira] [Updated] (OFBIZ-4772) xml validation: Invalid attribute width in /ofbiz/applications/product/widget/catalog/ImageManagementForms.xml

2012-03-29 Thread Francis ANDRE (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis ANDRE updated OFBIZ-4772: - Attachment: ofbiz.patch > xml validation: Invalid attribute width in > /ofbiz/applications/p

[jira] [Commented] (OFBIZ-4772) xml validation: Invalid attribute width in /ofbiz/applications/product/widget/catalog/ImageManagementForms.xml

2012-03-29 Thread Erwan de FERRIERES (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241532#comment-13241532 ] Erwan de FERRIERES commented on OFBIZ-4772: --- Hi Francis, to be included in OFBi

[jira] [Commented] (OFBIZ-860) Shark Integration - need to map and add xpdl participants into OFBiz

2012-03-29 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241494#comment-13241494 ] Pierre Smits commented on OFBIZ-860: ThIs issue can be set to closes as shark is going

[jira] [Updated] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-29 Thread Wai (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-4768: --- Attachment: ofbiz-4768.patch after-sample-webtools.png after-sample-partymgr.png

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-29 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241391#comment-13241391 ] Jacques Le Roux commented on OFBIZ-4768: I will try to have a look...

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-29 Thread Erwan de FERRIERES (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241377#comment-13241377 ] Erwan de FERRIERES commented on OFBIZ-4768: --- Hi Wai, this sure needs a discussi

[jira] [Updated] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-29 Thread Erwan de FERRIERES (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-4768: -- Description: Improvement to flatgrey theme. was: Improvement to flatgray theme.

[jira] [Assigned] (OFBIZ-4770) editCalEvent not use label system on status drop-down

2012-03-29 Thread Erwan de FERRIERES (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-4770: - Assignee: Erwan de FERRIERES > editCalEvent not use label system on status dr

[jira] [Commented] (OFBIZ-4772) xml validation: Invalid attribute width in /ofbiz/applications/product/widget/catalog/ImageManagementForms.xml

2012-03-29 Thread Francis ANDRE (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241342#comment-13241342 ] Francis ANDRE commented on OFBIZ-4772: -- Index: framework/widget/dtd/widget-form.xsd =

[jira] [Created] (OFBIZ-4772) xml validation: Invalid attribute width in /ofbiz/applications/product/widget/catalog/ImageManagementForms.xml

2012-03-29 Thread Francis ANDRE (Created) (JIRA)
xml validation: Invalid attribute width in /ofbiz/applications/product/widget/catalog/ImageManagementForms.xml -- Key: OFBIZ-4772 URL: https://issues.apach

Re: Renaming some ant tasks to improve consistency

2012-03-29 Thread Jacopo Cappellato
Ok, I have completed my work on this; however instead of running the new tasks from the old task I have preferred to print a message to inform the user about the new syntax; it seems to me that this is an easier transition because at some point we will remove. I also renamed a couple more tasks

[jira] [Updated] (OFBIZ-4771) Renamed some ant tasks for consistency, improved descriptions, removed 2 redundant tasks

2012-03-29 Thread Jacopo Cappellato (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-4771: - Attachment: ant-targets.patch > Renamed some ant tasks for consistency, improved desc

[jira] [Created] (OFBIZ-4771) Renamed some ant tasks for consistency, improved descriptions, removed 2 redundant tasks

2012-03-29 Thread Jacopo Cappellato (Created) (JIRA)
Renamed some ant tasks for consistency, improved descriptions, removed 2 redundant tasks Key: OFBIZ-4771 URL: https://issues.apache.org/jira/browse/OFBIZ-4771 Pr

[jira] [Updated] (OFBIZ-3894) Refactor Email handling

2012-03-29 Thread Nicolas Malin (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-3894: - Attachment: OFBIZ-3894.patch Hi Erwan, is possible to commit the last patch on email refactoring

[jira] [Updated] (OFBIZ-4770) editCalEvent not use label system on status drop-down

2012-03-29 Thread Nicolas Malin (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4770: - Attachment: OFBIZ-4470.patch > editCalEvent not use label system on status drop-down > --

[jira] [Created] (OFBIZ-4770) editCalEvent not use label system on status drop-down

2012-03-29 Thread Nicolas Malin (Created) (JIRA)
editCalEvent not use label system on status drop-down - Key: OFBIZ-4770 URL: https://issues.apache.org/jira/browse/OFBIZ-4770 Project: OFBiz Issue Type: Improvement Components: wo

Re: svn commit: r1306777 - /ofbiz/trunk/build.xml

2012-03-29 Thread Nicolas Malin
Hi jacopo, simple but powerful improvement for production :) Le 29/03/2012 12:02, jaco...@apache.org a écrit : Author: jacopoc Date: Thu Mar 29 10:02:35 2012 New Revision: 1306777 URL: http://svn.apache.org/viewvc?rev=1306777&view=rev Log: Added new ant task to start OFBiz as a process in the

[jira] [Created] (OFBIZ-4769) Editing of product suppliers is not working for the Germany locale

2012-03-29 Thread Sergei Biletnikov (Created) (JIRA)
Editing of product suppliers is not working for the Germany locale -- Key: OFBIZ-4769 URL: https://issues.apache.org/jira/browse/OFBIZ-4769 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-4768) Improvement for flatgray theme

2012-03-29 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241068#comment-13241068 ] Pierre Smits commented on OFBIZ-4768: - Looking at the before and after shots of partym

[jira] [Closed] (OFBIZ-3483) If his/her gender is editable by a customer, the service "getPartyNameForDate" should include it if available

2012-03-29 Thread Sascha Rodekamp (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-3483. -- Resolution: Fixed Fix Version/s: SVN trunk Hi Sebastian, you Patch is in Trunk @Rev 1306

[jira] [Updated] (OFBIZ-4768) Improvement for flatgray theme

2012-03-29 Thread Wai (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-4768: --- Attachment: before-sample-webtools.png before-sample-partymgr.png before-sample-catalo

[jira] [Closed] (OFBIZ-4744) ProductStoreCartAwareEvents: wrong check for website in setSessionProductStore

2012-03-29 Thread Sascha Rodekamp (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4744. -- Resolution: Fixed Fix Version/s: Release Branch 11.04 Release Branch 1

[jira] [Closed] (OFBIZ-4762) runSubscriptionAutoReorders places duplicate orderIds

2012-03-29 Thread Sascha Rodekamp (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4762. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04

Re: Discussion: Mini-language Overhaul

2012-03-29 Thread Jacopo Cappellato
Hi David, it is really interesting discussion. I understand the advantage of inlining service implementation in service definition; however I think that we could achieve a similar goal by implementing the service with a Groovy method and by defining some mechanism to declare in/out parameters a