[jira] [Commented] (OFBIZ-4757) Cobertura targets fail

2012-03-30 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243055#comment-13243055 ] Pierre Smits commented on OFBIZ-4757: - The above mentioned files are not generated, be

[jira] [Updated] (OFBIZ-4757) Cobertura targets fail

2012-03-30 Thread Pierre Smits (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4757: Environment: UBUNTU 10.04 LTS, Mac OS X 10.6.8 > Cobertura targets fail > -

[jira] [Commented] (OFBIZ-4742) Portlet Widget

2012-03-30 Thread Erwan de FERRIERES (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242731#comment-13242731 ] Erwan de FERRIERES commented on OFBIZ-4742: --- Olivier, your patchs are in the br

[jira] [Commented] (OFBIZ-4774) Include meta tag 'generator' in the ecommerce theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242719#comment-13242719 ] Jacques Le Roux commented on OFBIZ-4774: Could be, but not sure company will want

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242707#comment-13242707 ] Jacques Le Roux commented on OFBIZ-4768: >From screenshots, I'm not quite sure I p

Re: code simplification

2012-03-30 Thread Mansour Al Akeel
Yeah, I would do the same to make sure I am not breaking anything, if I am not sure about that piece of code. On Fri, Mar 30, 2012 at 2:13 PM, Erwan de FERRIERES wrote: > Le 30/03/2012 08:25, Pierre Smits a écrit : > >> Hi Erwan, >> >> Why this question? Shouldn't having made a JIRA issue for th

Re: code simplification

2012-03-30 Thread Erwan de FERRIERES
Le 30/03/2012 08:25, Pierre Smits a écrit : Hi Erwan, Why this question? Shouldn't having made a JIRA issue for this not have been enough? It seems to me that starting a discussion for every piece of code here is overkill. Just to check if someone knew why the array was still used, and why it

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Wai (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242548#comment-13242548 ] Wai commented on OFBIZ-4768: I agree with Adrian that the visual presentation is highly subjec

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Pierre Smits (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242491#comment-13242491 ] Pierre Smits commented on OFBIZ-4768: - I agree with you all in that the appeal of a th

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242465#comment-13242465 ] Jacques Le Roux commented on OFBIZ-4768: One thing I prefer in other themes is the

Re: Discussion: Mini-language Overhaul

2012-03-30 Thread Adrian Crum
On Mar 16, 2012, at 12:49 AM, David E Jones wrote: This is an interesting point. I thought about it a lot for Moqui and ended up doing much more simple XML Actions, though actually enhancing the entity find operations, and changed them to match the API better (and handle things like the current f

[jira] [Commented] (OFBIZ-4773) Migrate to JACOCO for code coverage analysis

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242276#comment-13242276 ] Jacques Le Roux commented on OFBIZ-4773: Pierre, I suggest to discuss that on dev

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Adrian Crum (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242263#comment-13242263 ] Adrian Crum commented on OFBIZ-4768: Visual theme "improvements" can be very subjectiv

[jira] [Updated] (OFBIZ-4774) Include meta tag 'generator' in the ecommerce theme

2012-03-30 Thread Pierre Smits (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4774: Attachment: OFBIZ-4774-eCommerce-meta-tag-for-generator.patch > Include meta tag 'generator' i

[jira] [Created] (OFBIZ-4774) Include meta tag 'generator' in the ecommerce theme

2012-03-30 Thread Pierre Smits (Created) (JIRA)
Include meta tag 'generator' in the ecommerce theme Key: OFBIZ-4774 URL: https://issues.apache.org/jira/browse/OFBIZ-4774 Project: OFBiz Issue Type: Improvement Components: spec

Re: svn commit: r1307302 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

2012-03-30 Thread Jacques Le Roux
Hi Hans, Interesting, I was trying to check https://issues.apache.org/jira/browse/OFBIZ-1866 recently. I will have a new try (of course I will not be annoyed if someone beats me on it ;o) Jacques From: Author: hansbak Date: Fri Mar 30 08:25:41 2012 New Revision: 1307302 URL: http://svn.ap

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Jacques Le Roux
+1 Jacques From: "Pierre Smits" +1 Op 30 maart 2012 09:02 schreef Jacopo Cappellato < jacopo.cappell...@hotwaxmedia.com> het volgende: another nice thing we could do, merely esthetic, is to rename "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat". Then the commands will be like: ofbiz load-dem

[jira] [Updated] (OFBIZ-4773) Migrate to JACOCO for code coverage analysis

2012-03-30 Thread Pierre Smits (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4773: Affects Version/s: SVN trunk > Migrate to JACOCO for code coverage analysis > -

[jira] [Created] (OFBIZ-4773) Migrate to JACOCO for code coverage analysis

2012-03-30 Thread Pierre Smits (Created) (JIRA)
Migrate to JACOCO for code coverage analysis Key: OFBIZ-4773 URL: https://issues.apache.org/jira/browse/OFBIZ-4773 Project: OFBiz Issue Type: Improvement Reporter: Pierre Smits It ap

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Erwan de FERRIERES
+1 2012/3/30 Jacopo Cappellato : > another nice thing we could do, merely esthetic, is to rename > "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat". > Then the commands will be like: > > ofbiz load-demo > ofbiz run-tests > ofbiz start > ofbiz stop > > etc... > > Jacopo > > On Mar 29, 2012, at 5:34 PM

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Deepak Dixit
+1 Thanks & Regards -- Deepak Dixit On Mar 30, 2012, at 12:32 PM, Jacopo Cappellato wrote: > another nice thing we could do, merely esthetic, is to rename > "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat". > Then the commands will be like: > > ofbiz load-demo > ofbiz run-tests > ofbiz start > o

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Tim Ruppert
+1 Cheers, Ruppert On Mar 30, 2012, at 1:05 AM, Pierre Smits wrote: > +1 > > Op 30 maart 2012 09:02 schreef Jacopo Cappellato < > jacopo.cappell...@hotwaxmedia.com> het volgende: > >> another nice thing we could do, merely esthetic, is to rename >> "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat".

Re: svn commit: r1305898 - in /ofbiz/trunk/applications: order/webapp/ordermgr/order/ order/webapp/ordermgr/quote/ party/webapp/partymgr/WEB-INF/actions/party/ party/webapp/partymgr/party/contactmecht

2012-03-30 Thread Jacopo Cappellato
Hi Chatree, the issue should be fixed by rev. 1307288. I didn't test the email report (so please let me know if this fixes doesn't solve the problem) but I am rather confident that it should be ok now. Jacopo On Mar 30, 2012, at 7:14 AM, Jacopo Cappellato wrote: > Hi Chatree, > > I am lookin

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Pierre Smits
+1 Op 30 maart 2012 09:02 schreef Jacopo Cappellato < jacopo.cappell...@hotwaxmedia.com> het volgende: > another nice thing we could do, merely esthetic, is to rename > "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat". > Then the commands will be like: > > ofbiz load-demo > ofbiz run-tests > ofbiz st

Re: Renaming some ant tasks to improve consistency

2012-03-30 Thread Jacopo Cappellato
another nice thing we could do, merely esthetic, is to rename "ant.sh"/"ant.bat" to "ofbiz.sh"/"ofbiz.bat". Then the commands will be like: ofbiz load-demo ofbiz run-tests ofbiz start ofbiz stop etc... Jacopo On Mar 29, 2012, at 5:34 PM, Jacopo Cappellato wrote: > Ok, > > I have completed my

Re: code simplification

2012-03-30 Thread Jacques Le Roux
+1, don't see the need from code snippet in Erwan's email (ie did not check code, but I guess it does not make sense to have an array with 1 value) Jacques From: "Mansour Al Akeel" For me, it makes happy when code get cleaned as we go. On Thu, Mar 29, 2012 at 4:55 PM, Erwan de FERRIERES w