Job Manager

2012-08-05 Thread Adrian Crum
I just committed a bunch of changes to the Job Manager group of classes. The changes help simplify the code and hopefully make the Job Manager more robust. On the other hand, I might have broken something. ;) I will monitor the mailing list for problems. I believe the JobPoller settings in

[jira] [Created] (OFBIZ-4981) Configured GL accounts don't appear for the product

2012-08-05 Thread BREMA Dev Team (JIRA)
BREMA Dev Team created OFBIZ-4981: - Summary: Configured GL accounts don't appear for the product Key: OFBIZ-4981 URL: https://issues.apache.org/jira/browse/OFBIZ-4981 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-4981) Configured GL accounts don't appear for the product

2012-08-05 Thread BREMA Dev Team (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BREMA Dev Team updated OFBIZ-4981: -- Attachment: ProductGlAccounts.diff Configured GL accounts don't appear for the product

[jira] [Updated] (OFBIZ-4981) Configured GL accounts don't appear for the product

2012-08-05 Thread BREMA Dev Team (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BREMA Dev Team updated OFBIZ-4981: -- Description: EditProductGlAccounts screen allows to assign GL account but does not show any

[jira] [Closed] (OFBIZ-4970) correct javascript:void(); to javascript:void(0); to make it syntax valid

2012-08-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4970. -- Resolution: Fixed Thanks for report Leon, Actually clear is not a new function. I found some

[jira] [Updated] (OFBIZ-4970) correct javascript:void(); to javascript:void(0); to make it syntax valid

2012-08-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4970: --- Fix Version/s: Release Branch 12.04 Release Branch 11.04 correct

[jira] [Commented] (OFBIZ-4970) correct javascript:void(); to javascript:void(0); to make it syntax valid

2012-08-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428836#comment-13428836 ] Jacques Le Roux commented on OFBIZ-4970: About the bugs I talked about see trunk

Re: svn commit: r1369503 - in /ofbiz/trunk/specialpurpose/workflow/src/org/ofbiz/workflow: WorkflowEngine.java client/StartActivityJob.java

2012-08-05 Thread Jacques Le Roux
I will move it to Attic soon though. I guess Shark will stay as it was (in Attic now) Jacques From: adri...@apache.org Author: adrianc Date: Sat Aug 4 22:40:58 2012 New Revision: 1369503 URL: http://svn.apache.org/viewvc?rev=1369503view=rev Log: Updated Workflow component to compile with

Re: svn commit: r1369486 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/job/PersistedServiceJob.java

2012-08-05 Thread Jacques Le Roux
Hi Adrian, Your comment does not seem to fit with your change Jacques From: adri...@apache.org Author: adrianc Date: Sat Aug 4 22:07:18 2012 New Revision: 1369486 URL: http://svn.apache.org/viewvc?rev=1369486view=rev Log: Fixed a costly call to UtilValidate. Modified:

Re: svn commit: r1369486 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/job/PersistedServiceJob.java

2012-08-05 Thread Adrian Crum
UtilValidate.isEmpty(Object) calls ObjectType.isEmpty(Object) - which performs a series of instanceof checks. Calling UtilValidate.isEmpty(String) avoids the expensive instanceof checks. -Adrian On 8/5/2012 12:58 PM, Jacques Le Roux wrote: Hi Adrian, Your comment does not seem to fit with

Re: Job Manager

2012-08-05 Thread Adrian Crum
On 8/5/2012 11:02 AM, Adrian Crum wrote: I just committed a bunch of changes to the Job Manager group of classes. The changes help simplify the code and hopefully make the Job Manager more robust. On the other hand, I might have broken something. ;) I will monitor the mailing list for

Re: svn commit: r1369486 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/job/PersistedServiceJob.java

2012-08-05 Thread Jacques Le Roux
Right, I updated the commit comment, can't hurt Jacques From: Adrian Crum adrian.c...@sandglass-software.com UtilValidate.isEmpty(Object) calls ObjectType.isEmpty(Object) - which performs a series of instanceof checks. Calling UtilValidate.isEmpty(String) avoids the expensive instanceof

[jira] [Commented] (OFBIZ-4105) findOrdersToPickMove: EntityListIterator not closed if no Picklist generated

2012-08-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428853#comment-13428853 ] Jacques Le Roux commented on OFBIZ-4105: I reverted from R9.04, there was an error

[jira] [Comment Edited] (OFBIZ-4105) findOrdersToPickMove: EntityListIterator not closed if no Picklist generated

2012-08-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428853#comment-13428853 ] Jacques Le Roux edited comment on OFBIZ-4105 at 8/5/12 2:04 PM:

Re: Job Manager

2012-08-05 Thread Brett Palmer
Adrian, Thanks for the update. Here are some feedback points on your listed items: 1. JobPoller get out-of-memor error. We've seen this a lot in production servers when the JobSandbox table is not constantly pruned of old records. It would be nice if the poller restricted its search for only

Re: Job Manager

2012-08-05 Thread Adrian Crum
Thanks Brett! I will be working on this again next weekend, and I will try to include your suggestions. -Adrian On 8/5/2012 4:53 PM, Brett Palmer wrote: Adrian, Thanks for the update. Here are some feedback points on your listed items: 1. JobPoller get out-of-memor error. We've seen this