[jira] [Closed] (OFBIZ-4992) GenericEntity.get should not clutter logs with warnings

2013-01-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4992. -- Resolution: Duplicate Duplicate of OFBIZ-4987 GenericEntity.get should not

[jira] [Commented] (OFBIZ-4987) printing IllegalArgumentException instead of throwing it because Map interface specification does not allow throwing that exception

2013-01-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547748#comment-13547748 ] Jacques Le Roux commented on OFBIZ-4987: I believe this has been discussed on dev

[jira] [Commented] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547765#comment-13547765 ] Jose Manuel Vivó Arnal commented on OFBIZ-5122: --- Hello Jacques, Sorry about

[jira] [Comment Edited] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547765#comment-13547765 ] Jose Manuel Vivó Arnal edited comment on OFBIZ-5122 at 1/9/13 8:27 AM:

[jira] [Updated] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Manuel Vivó Arnal updated OFBIZ-5122: -- Affects Version/s: (was: Release 09.04.01) (was:

[jira] [Updated] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Manuel Vivó Arnal updated OFBIZ-5122: -- Attachment: (was: DBCPConnectionFactory-patch.txt) Memory leak due to

[jira] [Comment Edited] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread JIRA
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547765#comment-13547765 ] Jose Manuel Vivó Arnal edited comment on OFBIZ-5122 at 1/9/13 8:52 AM:

[jira] [Commented] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1354#comment-1354 ] Jacques Le Roux commented on OFBIZ-5122: Jose, About the patch, it's ok don't

[jira] [Assigned] (OFBIZ-5122) Memory leak due to transaction management using DBCP and MySQL

2013-01-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5122: -- Assignee: Jacques Le Roux Memory leak due to transaction management using DBCP

[jira] [Created] (OFBIZ-5123) calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule

2013-01-09 Thread Praveen Agrawal (JIRA)
Praveen Agrawal created OFBIZ-5123: -- Summary: calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule Key: OFBIZ-5123 URL:

[jira] [Updated] (OFBIZ-5123) calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule

2013-01-09 Thread Praveen Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praveen Agrawal updated OFBIZ-5123: --- Attachment: OFBiz-5123.patch Patch is attached for 10.04 branch.

Double-Checked Locking.

2013-01-09 Thread Sumit Pandit
As per Fortyfy analysis report - Double-checked locking is an incorrect idiom that does not achieve the intended effect F ollowing code is written to guarantee that only one Fitzer() object is ever allocated, but does not want to pay the cost of synchronization every time this code is called.

Re: [spam] Double-Checked Locking.

2013-01-09 Thread Adrian Crum
Thank you. DCL has been discussed in the past and the community is in agreement that it is a pattern to avoid. If you see DCL code in OFBiz, it is because no one has taken the time to fix it. -Adrian On 1/9/2013 1:04 PM, Sumit Pandit wrote: As per Fortyfy analysis report - Double-checked

Re: [spam] Double-Checked Locking.

2013-01-09 Thread dejc
Actually the community is not in agreement that it should be avoided, and in fact it should be used in many cases. The reason for this pattern in most of OFBiz is not to guarantee a single instance of an object but to improve performance, and the synchronized block with no if block kind of

Re: Double-Checked Locking.

2013-01-09 Thread Adrian Crum
I agree that the fix proposed in the original email is not a good idea. There are several good books that discuss why DCL should not be used, and they provide better ways to handle synchronization. -Adrian On 1/9/2013 4:15 PM, d...@me.com wrote: Actually the community is not in agreement

[jira] [Assigned] (OFBIZ-5123) calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule

2013-01-09 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-5123: --- Assignee: Anil K Patel calculateProductPrice doesn't return the Price from Virtual

[jira] [Closed] (OFBIZ-5123) calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule

2013-01-09 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-5123. --- calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant

[jira] [Comment Edited] (OFBIZ-5123) calculateProductPrice doesn't return the Price from Virtual Product Price rule if the variant doesn't have any price rule

2013-01-09 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549203#comment-13549203 ] Anil K Patel edited comment on OFBIZ-5123 at 1/9/13 11:54 PM: --