buildbot success in ASF Buildbot on ofbiz-branch11

2013-05-23 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch11 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-branch11/builds/78 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: forced: by IRC

[jira] [Created] (OFBIZ-5199) Complex Alias is not working with default value.

2013-05-23 Thread Deepak Dixit (JIRA)
Deepak Dixit created OFBIZ-5199: --- Summary: Complex Alias is not working with default value. Key: OFBIZ-5199 URL: https://issues.apache.org/jira/browse/OFBIZ-5199 Project: OFBiz Issue Type: Bug

buildbot success in ASF Buildbot on ofbiz-branch12

2013-05-23 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch12 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-branch12/builds/90 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: forced: by IRC

[jira] [Updated] (OFBIZ-5199) Complex Alias is not working with default value.

2013-05-23 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-5199: Attachment: OFBIZ-5199-R.patch OFBIZ-5199.patch Here is the patch for this issue.

[jira] [Closed] (OFBIZ-5198) Add a mean to collect and show the Requests Events durations using Metrics

2013-05-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5198. -- Resolution: Implemented Assignee: Jacques Le Roux Thanks Adrian for the explanation!

[jira] [Updated] (OFBIZ-5198) Add a mean to collect and show the Requests Events durations using Metrics

2013-05-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5198: --- Attachment: (was: OFBIZ-5198 metrics.patch) Add a mean to collect and show the

Re: svn commit: r1485601 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/metrics/ webapp/config/ webapp/dtd/ webapp/src/org/ofbiz/webapp/control/

2013-05-23 Thread Adrian Crum
This looks good, but please leave the thread-safe fields as final. See inline comment... On 5/23/2013 8:55 AM, jler...@apache.org wrote: Author: jleroux Date: Thu May 23 07:55:14 2013 New Revision: 1485601 URL: http://svn.apache.org/r1485601 Log: Add a mean to collect and show the Requests

Re: svn commit: r1485601 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/metrics/ webapp/config/ webapp/dtd/ webapp/src/org/ofbiz/webapp/control/

2013-05-23 Thread Jacques Le Roux
Yes sorry, this was a 1st try I did before changing directly in factory, I forgot to remove, I will. Always better to have at least 2 pairs of eyes... Jacques From: Adrian Crum adrian.c...@sandglass-software.com This looks good, but please leave the thread-safe fields as final. See inline

Re: svn commit: r1485601 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/metrics/ webapp/config/ webapp/dtd/ webapp/src/org/ofbiz/webapp/control/

2013-05-23 Thread Adrian Crum
Thanks. As you can see, adding metrics to OFBiz is fairly simple. That is why I objected to adding redundant code to the Metrics classes. -Adrian On 5/23/2013 9:57 AM, Jacques Le Roux wrote: Yes sorry, this was a 1st try I did before changing directly in factory, I forgot to remove, I

[jira] [Created] (OFBIZ-5200) Prevent caching of json ajax request

2013-05-23 Thread JIRA
Roberto Benítez Monje created OFBIZ-5200: Summary: Prevent caching of json ajax request Key: OFBIZ-5200 URL: https://issues.apache.org/jira/browse/OFBIZ-5200 Project: OFBiz Issue

Re: svn commit: r1485601 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/metrics/ webapp/config/ webapp/dtd/ webapp/src/org/ofbiz/webapp/control/

2013-05-23 Thread Jacques Le Roux
Yes, I should have thought about using the model, rather than mucking around with Metric classes. But it was a bit more complicated so I got this wrong way. BTW, I just thought about something. Convention above configuration is often good, but here the metrics names rely on hand writing. So

Re: svn commit: r1485601 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/metrics/ webapp/config/ webapp/dtd/ webapp/src/org/ofbiz/webapp/control/

2013-05-23 Thread Jacques Le Roux
Yes, I should have thought about using the model, rather than mucking around with Metric classes. But it was a bit more complicated so I went this wrong way. BTW, I just thought about something. Convention above configuration is often good, but here the metrics names rely on hand writing. So

[jira] [Commented] (OFBIZ-5146) in ModelViewEntity.java, a Map is built with only a few of the SQL functions, extend the map to include the MONTH and Year functions.

2013-05-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665421#comment-13665421 ] Jacques Le Roux commented on OFBIZ-5146: Adrian, I guess we can now, right?