[jira] [Created] (OFBIZ-5439) Order Return Process doesn't override the Order Adjustment Amount that is provided from Return Screen GUI

2013-12-18 Thread Praveen Agrawal (JIRA)
Praveen Agrawal created OFBIZ-5439: -- Summary: Order Return Process doesn't override the Order Adjustment Amount that is provided from Return Screen GUI Key: OFBIZ-5439 URL: https://issues.apache.org/jira/browse/O

Re: svn commit: r1552073 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2013-12-18 Thread Jacques Le Roux
OK, then I will add one to my last change. This shows again that exceptions are a kind of goto :/ Jacques On Thursday, December 19, 2013 12:24 AM Adrian Crum adrian.c...@sandglass-software.com > In the past, some committers have complained that the source of the > exception is obscured by calli

buildbot failure in ASF Buildbot on ofbiz-trunk-ARM

2013-12-18 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-ARM while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk-ARM/builds/772 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-cal-2_ubuntu_ARM Build Reason: scheduler Bui

Re: svn commit: r1552073 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2013-12-18 Thread Adrian Crum
In the past, some committers have complained that the source of the exception is obscured by calling code (which may quietly swallow it), so the preferred method is to log the exception before throwing it. Adrian Crum Sandglass Software www.sandglass-software.com On 12/18/2013 6:16 PM, Jacques

Re: svn commit: r1552073 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2013-12-18 Thread Jacques Le Roux
BTW Adrian, Do we really need to have a pattern like Debug.logError(e, "Exception thrown while creating ConnectionFactoryInterface instance: ", module); throw new IllegalStateException("Error loading ConnectionFactoryInterface class: " + e); throw new IllegalStateException("Error lo

buildbot success in ASF Buildbot on ofbiz-trunk-ARM

2013-12-18 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-ARM while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk-ARM/builds/771 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-cal-2_ubuntu_ARM Build Reason: scheduler

Re: svn commit: r1552073 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2013-12-18 Thread Jacques Le Roux
Indeed, done at r1552120 Jacques On Wednesday, December 18, 2013 9:33 PM adrian.c...@sandglass-software.com adrian.c...@sandglass-software.com > Jacques, > > Thank you for working on this. > > It might be best to have the AtomicReference update outside the > try-catch block. So... > > 1. Try

Re: svn commit: r1552073 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2013-12-18 Thread adrian . crum
Jacques, Thank you for working on this. It might be best to have the AtomicReference update outside the try-catch block. So... 1. Try to create a new sequencer. 2. If successful, update the AtomicReference. The end result will be the same, but (from my perspective) it will be easier to re