Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
Jacopo, I stand corrected! yes indeed the wrong Issue. not 2699 but OFBIZ-4053, you are right. Thank you and Scott for supporting the idea, so we get the quality of OFBiz better. Left one open question to answer, how we are going to include user interface tests. Once we had selenium i

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Jacopo Cappellato
A few days ago Scott and I had already discussed about unit tests for the new query builder and they will come soon: the new API will not go into any release without unit tests. In fact I think that Scott told you that he is not going to work on OFBIZ-5699 because he is busy with the query build

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
Like I said in my earlier email, new unit tests only prevent future regression they don't serve as an indicator to the quality of the contribution they're submitted with. If I were to provide unit tests for the EntityQuery class it would tell you exactly zero about whether or not upgrading exis

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
So Scott, you introduce a new API named EntityQuery without a unit test, then you are going to replace the existing well working API with something which is not tested continuously i love the idea :-( and then everybody asking for reliability and quality. Regards, Hans On 06/10/14

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Jacopo Cappellato
a big +1 to put more "social" pressure on contributors to provide and implement unit tests; it will be a big win when we all new code will be committed with unit tests, so I agree that it is the way to go but I just want to be realistic and enforcing this rule may have a big impact on the projec

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Adrian Crum
Unit tests should be encouraged, but not required. I don't know what you mean by "When the OFBiz system was initially implemented this was already recognized that automated tests are required for a quality product." If you are referring to the OFBiz "product" then it is important to remember t

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
On 6/10/2014, at 3:24 pm, Hans Bakker wrote: > On 06/10/14 09:15, Scott Gray wrote: >> Hi Hans, >> .. >> Lastly, the majority of our tests are implemented in mini-lang and I'm >> really not a fan of it at all. If there were support for converting them to >> groovy (do we even support g

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
On 06/10/14 09:15, Scott Gray wrote: Hi Hans, .. Lastly, the majority of our tests are implemented in mini-lang and I'm really not a fan of it at all. If there were support for converting them to groovy (do we even support groovy tests?), I'd be glad to help lead that change. Try if g

Re: Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Scott Gray
Hi Hans, Two thoughts: 1. Are we sure we want to raise the barrier for any new potential major contributions? We don't receive so many as it is. Same thing with bug reports, would we ignore them if they don't have a test? Would we delay fixing the issue until someone feels like writing one?

Proposal: Mandatory JUnit tests for new functions

2014-10-05 Thread Hans Bakker
Good morning, If you are following the relatively new developments in software development you will be aware of continuous integration or the next step: continuous deployment. This is all part of the 'continuous improvement' principle. When the OFBiz system was initially implemented this was a

[jira] [Commented] (OFBIZ-5699) NPE on a virtual product in configurable good

2014-10-05 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159782#comment-14159782 ] Hans Bakker commented on OFBIZ-5699: Or provide a junit test case which shows the erro

Re: entity-auto improvement ?

2014-10-05 Thread Nicolas Malin
I opened the issue https://issues.apache.org/jira/browse/OFBIZ-5800 for any comments on the given resolution. I will continue my tests to ensure that it don't create any regression. Nicolas Le 23/09/2014 00:09, Nicolas Malin a écrit : Hello all, Currently, I works to convert humanres service

[jira] [Updated] (OFBIZ-5800) Manage multi pk with sub-sequence on entity-auto

2014-10-05 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-5800: - Attachment: OFBIZ-5800.patch Any comments are welcome :) . > Manage multi pk with sub-sequence on

[jira] [Updated] (OFBIZ-5800) Manage multi pk with sub-sequence on entity-auto

2014-10-05 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-5800: - Priority: Minor (was: Major) > Manage multi pk with sub-sequence on entity-auto > ---

[jira] [Created] (OFBIZ-5800) Manage multi pk with sub-sequence on entity-auto

2014-10-05 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-5800: Summary: Manage multi pk with sub-sequence on entity-auto Key: OFBIZ-5800 URL: https://issues.apache.org/jira/browse/OFBIZ-5800 Project: OFBiz Issue Type: Im

[jira] [Resolved] (OFBIZ-5734) Convert Product association entity CRUD service from simple to entity-auto

2014-10-05 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin resolved OFBIZ-5734. -- Resolution: Fixed Fix Version/s: Upcoming Branch Done on trunk at revision 1629523. I wi

[jira] [Commented] (OFBIZ-5699) NPE on a virtual product in configurable good

2014-10-05 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159636#comment-14159636 ] Nicolas Malin commented on OFBIZ-5699: -- Guillaume, do you have testing data ? I didn'

[jira] [Updated] (OFBIZ-5799) Can't mount root web app

2014-10-05 Thread Josip Almasi (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josip Almasi updated OFBIZ-5799: Attachment: OFBIZ-5799.patch Solves StringIndexOutOfBoundsException in CatalogUrlServlet.makeCatalog

[jira] [Created] (OFBIZ-5799) Can't mount root web app

2014-10-05 Thread Josip Almasi (JIRA)
Josip Almasi created OFBIZ-5799: --- Summary: Can't mount root web app Key: OFBIZ-5799 URL: https://issues.apache.org/jira/browse/OFBIZ-5799 Project: OFBiz Issue Type: Bug Components: pr

Re: ELI Finalize Message

2014-10-05 Thread Scott Gray
My bad, fixed in r1629480 after a lot of time spent staring at the problem without seeing it. Thanks Scott On 5/10/2014, at 6:11 pm, Jacopo Cappellato wrote: > yes I got the same > > Jacopo > > On Oct 4, 2014, at 6:55 PM, Adrian Crum > wrote: > >> New log message from EntityListIterator: