Re: Refactoring code and JIRA

2015-12-23 Thread Ron Wheeler
If you raise a JIRA for each refactoring exercise then people can comment on your plan. The scope of the JIRA should be short so you can finish it, test it and close it before a lot of other bugs/enhancements get done that might affect the same code. The scope should be short so that if you

Re: Refactoring code and JIRA

2015-12-23 Thread Taher Alkhateeb
Thank you Jacques and Pierre Ok so perhaps a middle ground is to have a central JIRA issue to which I refer all commits. This way I can be lean in cleaning up the code base. Oh and please disregard the other email, it was my bad for sending twice Regards, Taher Alkhateeb On Wed, Dec 23, 2015 a

Refactoring code without JIRA

2015-12-23 Thread Taher Alkhateeb
Hi Everyone, Many times I feel the necessity to refactor and cleanup the code base and I don't see a necessity for issuing a JIRA for that. Do we have a policy on pure refactoring (no functional change)? I would like to refactor code without issuing a JIRA. Examples are function and variable rena

Re: Refactoring code and JIRA

2015-12-23 Thread Jacques Le Roux
I assume pure code refactoring with no functional changes does not need a Jira. But what you could do is many commits with a sole Jira issue, for people to refer in a sole place in case of need. Jacques Le 23/12/2015 18:33, Taher Alkhateeb a écrit : Hi everyone, Many times I have the itch to

Re: Refactoring code and JIRA

2015-12-23 Thread Pierre Smits
HI Taher, JIRA issues tell our users what to expect when it comes to updating/upgrading their production environments. And it tells potential adopters what they can expect. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketpla

Refactoring code and JIRA

2015-12-23 Thread Taher Alkhateeb
Hi everyone, Many times I have the itch to cleanup the code base but not sure whether a JIRA issue is necessary. Do i need to issue a JIRA for pure code refactoring (no functional change)? This would include things like function and variable rename, breaking up big classes and functions, adding u

[jira] [Commented] (OFBIZ-6706) The Widget-style of a menuItem in his link when the menu is selected

2015-12-23 Thread Julien NICOLAS (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069626#comment-15069626 ] Julien NICOLAS commented on OFBIZ-6706: --- It was a question, have I to define "close"