Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

2016-10-03 Thread Harsh Vijaywargiya
Hi Jacques, This is good idea to keep such information on JIRA ticket so anyone can easily pick it. I have created https://issues.apache.org/jira/browse/OFBIZ-8341 If I find more such classes then I will add in this ticket, and will also try to provide the patch for this soon. Thanks &

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

2016-10-03 Thread Jacques Le Roux
Hi Harsh, Any chances about that, should we not create a Jira? Thanks Jacques Le 17/09/2016 à 13:52, Harsh Vijaywargiya a écrit : Hi Jacques, Ashish I also noted few classes with such patterns during clean up, and in first attempt I just cleaned the default TODOs. I will provide a patch

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

2016-10-03 Thread Jacques Le Roux
Hi Ashish, At r1763154 I did all the similar trivial changes. To All, Adam, I wonder about keeping this code put in in 2008 with http://svn.apache.org/viewvc?view=revision=713573 /** * Finds product variants based on a product ID and a distinct feature. */ public static Map

Re: svn commit: r1762227 - in /ofbiz/trunk: applications/content/src/main/java/org/apache/ofbiz/content/data/ applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/fed ex/ framework/

2016-10-03 Thread Jacques Le Roux
Thanks Jacopo for all this good work and especially detailed report. I only think about one thing which is not new but I never noticed before. in build.gradle we load freemarker 2.3.24 with compile 'org.freemarker:freemarker:2.3.24-incubating' And in the FreeMarkerWorkerclass we have this