Re: svn commit: r1767101 - in /ofbiz/trunk: applications/accounting/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ applications/party/servicedef/ applications/product/mi

2016-11-01 Thread Arun Patidar
Hi Jacques, Thanks for reviewing and suggesting improvements. I will look into this and fix it in my next attempt very soon. -- Thanks & Regards --- Arun Patidar Manager,Enterprise Software Development HotWax Mediawww.hotwaxsystems.com On Wed, Nov 2, 2016 at 2:25 AM, Jacques Le Roux <

Re: Groovy and semicolon at EOL

2016-11-01 Thread Jacques Le Roux
Hi Rishi, It's not the first time we change a *simple thing* in all the source. I can live with that, you seem well organised :) BTW after appling the patch at OFBIZ-8652 I still find 57 trailing semicolons :) Thanks Jacques Le 01/11/2016 à 07:35, Rishi Solanki a écrit : Jacques, Yes we

Re: svn commit: r1767101 - in /ofbiz/trunk: applications/accounting/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ applications/party/servicedef/ applications/product/mi

2016-11-01 Thread Jacques Le Roux
Hi Arun, Very minor, but is there a reason why services_shipmentgateway.xml is still a bit weird (compared to other changes)? I mean how it's sorted (not always create/update/delete order) and why updateShipmentGatewayConfig and updateShipmentGatewayConfigType still in minilang ? Thanks

Re: Security page

2016-11-01 Thread Jacopo Cappellato
My preference is to keep the content as it is now, or create a security.html page: this page should contain the official CVEs (similarly to what we have now) and not suggestions, or how-to guides to keep the system secure (but we could add a link to this content, that should stay in the Wiki)

Re: Groovy and semicolon at EOL

2016-11-01 Thread Rishi Solanki
Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: