Re: Git for commiters

2017-02-18 Thread Scott Gray
I've been using git-svn for years, I don't think my setup involved as many steps as that document shows though. I think I just started from git svn init. The main advantages for me was to be able to stash works in progress and to make multiple local commits before pushing to svn. Regards Scott

Re: User Acceptance Test Cases For Ecommerce 14.12

2017-02-18 Thread Rishi Solanki
Folks, Added two more UAT as Category Navigation and Product Search . I observe some scope of improvements like UAT writing aren't following common patterns, I'll review and fix them soon. Soon we would add remaining in the

Re: svn commit: r1783427 - in /ofbiz/ofbiz-framework/trunk/framework/webtools: groovyScripts/entity/ template/entity/ widget/

2017-02-18 Thread Jacques Le Roux
Nicolas, OK Forget it, viewing your patch at OFBIZ-9217 I saw some properties set. But when you committed I saw no properties and wondered But all the files you committed already existed, had the properties already set. So in both cases it's OK. Anyway with the *svn:auto-props* set on the

Re: Git for commiters

2017-02-18 Thread Jacques Le Roux
Er, I want to know if some committers are using "Git for commiters" as described at https://cwiki.apache.org/confluence/display/OFBIZ/Git+for+committers ? How could I say that differently? This page is linked from http://ofbiz.apache.org/source-repositories.html I have no intentions yet, just

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Michael Brohl
Hi Pierre, my proposal was to deprecate mini lang, not to drop xml based definitions and configurations as a whole. Regards, Michael Am 18.02.17 um 13:12 schrieb Pierre Smits: I am inclined to say +1. But I see some concerns rising (with respect to some suggestions) with new additions,

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Jacques Le Roux
Le 18/02/2017 à 13:12, Pierre Smits a écrit : I am inclined to say +1. But I see some concerns rising (with respect to some suggestions) with new additions, e.g: 1. No more simple (entity-auto) services, ecas and secas in xml? Or only no more complex ones? Do we opt for Java, Groovy,

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Pierre Smits
I am inclined to say +1. But I see some concerns rising (with respect to some suggestions) with new additions, e.g: 1. No more simple (entity-auto) services, ecas and secas in xml? Or only no more complex ones? Do we opt for Java, Groovy, or leave that to the discretion of each

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Paul Foxworthy
+1 I have wondered how hard it would be to create an isomorphic conversion between minilang and a Groovy DSL - bidirectional conversion between the two. That would mean we could automatically convert the existing minilang to the DSL, and if there is anyone who prefers minilang, they could convert

Re: Welcome Swapnil Shah as a New Committer!

2017-02-18 Thread Arun Patidar
Congratulations and Welcome Swapnil !!! -- Thanks & Regards --- Arun Patidar Manager,Enterprise Software Development HotWax Mediawww.hotwaxsystems.com On Sat, Feb 18, 2017 at 12:26 PM, Aditya Sharma < aditya.sha...@hotwaxsystems.com> wrote: > Felicitations Swapnil Shah... > > Thanks &

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Jacques Le Roux
I agree with both of you. The recent FinAccount deadlock issue reported on dev ML is one example of the type of issues which would be easier to deal with with a Turing complete language or at least a better DSL. My 2 cts Jacques Le 18/02/2017 à 10:25, Taher Alkhateeb a écrit : +1 let's

Re: Git for commiters

2017-02-18 Thread Michael Brohl
Hi Jacques, what do you mean with "using"? What's the intention of your question? Regards, Michael Am 18.02.17 um 10:14 schrieb Jacques Le Roux: Hi, Is someone using "Git for commiters" as explained at https://cwiki.apache.org/confluence/display/OFBIZ/Git+for+committers ? Thanks

Re: Inconsistent String Comparisons

2017-02-18 Thread Michael Brohl
+1, thanks, Devanshu! Regards, Michael Am 09.01.17 um 10:22 schrieb Devanshu Vyas: Hello Devs, I found an inconsistency in the code for string comparison *statusId.equals("PRUN_COMPLETED")* whereas it should be written as *"PRUN_COMPLETED".equals(statusId)* cause the former can throw

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Taher Alkhateeb
+1 let's maintain but not add more to the pile, and try to replace everything written in minilang with other languages over time. I think your arguments and proposal are well founded and would really improve the health of this project. On Feb 18, 2017 12:17 PM, "Michael Brohl"

[PROPOSAL] deprecate mini lang

2017-02-18 Thread Michael Brohl
Hi everyone, we are currently working hard to make OFBiz a modern, quality, robust and easy to use framework. There are several ongoing initiatives like refactoring the core, UX, changing the build and plugin system and cleaning up the javadocs, only to mention a few. In mini lang I see

Re: svn commit: r1783427 - in /ofbiz/ofbiz-framework/trunk/framework/webtools: groovyScripts/entity/ template/entity/ widget/

2017-02-18 Thread Jacques Le Roux
Hi Nicolas, Not totally sure, but it seems it would be good if you could put the svn config file in the right place. This to possibly avoid all those false changes below. If you did, forget it, it's something else and I don't know what). Else see the committers wiki page for more... Thanks

Git for commiters

2017-02-18 Thread Jacques Le Roux
Hi, Is someone using "Git for commiters" as explained at https://cwiki.apache.org/confluence/display/OFBIZ/Git+for+committers ? Thanks Jacques

Re: Inconsistent String Comparisons

2017-02-18 Thread Jacques Le Roux
+1, I suggest a Jira to handle all cases like that Jacques Le 09/01/2017 à 10:22, Devanshu Vyas a écrit : Hello Devs, I found an inconsistency in the code for string comparison *statusId.equals("PRUN_COMPLETED")* whereas it should be written as *"PRUN_COMPLETED".equals(statusId)* cause the