buildbot success in on ofbiz-branch16

2017-06-20 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch16 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch16/builds/67 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1798912 - /ofbiz/tools/demo-backup/trunk-manual-only.sh

2017-06-20 Thread Jacques Le Roux
Not sure why but got this today :compileJava UP-TO-DATE :processResources UP-TO-DATE :classes UP-TO-DATE :jar UP-TO-DATE :assemble UP-TO-DATE :compileTestJava UP-TO-DATE :processTestResources UP-TO-DATE :testClasses UP-TO-DATE :test UP-TO-DATE :check UP-TO-DATE :build UP-TO-DATE :ofbiz

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-20 Thread Nicolas Malin
Hi, I agree with Scott, I check your code and I see no reason to don't commit it Nicolas Le 20/06/2017 à 07:47, Scott Gray a écrit : Hi Taher, The jira summary of changes sounds like a re-organization without any (intentional) changes in functionality. Personally I would just go ahead and

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-20 Thread Jacques Le Roux
Hi Taher, I'll try to have a look today. Jacques Le 19/06/2017 à 23:13, Taher Alkhateeb a écrit : Hey Folks. I know everyone's probably preoccupied. It would be great to get some feedback on OFBIZ-9392 though given how critical this piece of code is. I'd feel much better about committing