Re: buildbot failure in on ofbiz-branch16

2017-06-26 Thread Jacques Le Roux
Yes indeed, we already spoke about that in OFBIZ-9182 and it's surely better to use the Gradle wrapper (no need to ask infra to update Gradle) and to avoid the daemon default. Not sure it will be enough though, I see no reason why a Gradle daemon would keep the 8080 port open (never happened

Re: buildbot failure in on ofbiz-branch16

2017-06-26 Thread Taher Alkhateeb
I think the buildbot scripts might be faulty. I'll work on refactoring it to at least start using the embedded gradle wrapper with --no-daemon flag. We need to slowly isolate all causes On Mon, Jun 26, 2017 at 11:29 AM, Michael Brohl wrote: > Done in

Re: buildbot failure in on ofbiz-branch16

2017-06-26 Thread Jacques Le Roux
Hi Michael, Unfortunately it's unrelated. The change I made are only for the demos (trunk and stable). It's still not clear to me what is keeping the 8080 port open. I don't think it's a pending previous OFBiz instance. Because each build is started anew. At some point it was (not clear)

Re: buildbot failure in on ofbiz-branch16

2017-06-26 Thread Michael Brohl
Done in https://issues.apache.org/jira/browse/OFBIZ-9433 Am 26.06.17 um 10:27 schrieb Michael Brohl: There seems to be a problem with shutting down previous instances: SEVERE: Failed to initialize end point associated with ProtocolHandler ["http-nio-8080"] java.net.BindException: Address

Re: buildbot failure in on ofbiz-branch16

2017-06-26 Thread Michael Brohl
There seems to be a problem with shutting down previous instances: SEVERE: Failed to initialize end point associated with ProtocolHandler ["http-nio-8080"] java.net.BindException: Address already in use SEVERE: Failed to initialize connector [Connector[HTTP/1.1-8080]]

buildbot failure in on ofbiz-branch16

2017-06-26 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-branch16 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch16/builds/71 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2017-06-26 Thread Jacques Le Roux
OK, the shutdown command is somehow our SIGTERM, makes sense Jacques Le 26/06/2017 à 08:45, Taher Alkhateeb a écrit : I do not think we should send SIGTERM in the first place. The proper termination of OFBiz is with the --shutdown command which cleanly stops everything and calls the shutdown

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2017-06-26 Thread Taher Alkhateeb
I do not think we should send SIGTERM in the first place. The proper termination of OFBiz is with the --shutdown command which cleanly stops everything and calls the shutdown hook. The gradle task "terminateOfbiz" should only be used if the shutdown command fails (last resort) as cleary mentioned

Re: GL Patch

2017-06-26 Thread Jacques Le Roux
Hi Craig, If you have not too much changes in your OFBiz installation another way could be to get the last OFBiz version: 16.11.03 with more fixes in it. And yes this email would have been better in user ML. It's not about changing OFBiz but changing your installation. Thanks for the question

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2017-06-26 Thread Jacques Le Roux
Thanks Taher, I indeed missed that kill is not an atomic operation. I reverted at r1799852. Before reading your last message I wanted to propose to set a delay between the 2 operations. So SIGTERM fails. I'd really like to send SIGTERM before killing the process and only kill it if it's