Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

Inline On Sun, Sep 10, 2017 at 8:40 PM, Jacques Le Roux wrote: > I easily see 3 alternatives: > > 1. Swallow the exception, like we currently do. This should be forbidden in > all cases, I'd veto that!- > 2. Log an error and return a wrong result, like it's

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

I easily see 3 alternatives: 1. Swallow the exception, like we currently do. This should be forbidden in all cases, I'd veto that!- 2. Log an error and return a wrong result, like it's currently done by getShippableTotal() in the same class. That's what I proposed, but instead of returning

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

What I understand is that the patch is essentially changing the signature of most methods to throw an exception. On a first glance this seems to be putting the code in a worst state because now you're adding complexity for the caller to figure out how to handle these exceptions. What is the

Re: Services with no definition and usage

Here, it's not about Minilang but only service definitions Jacques Le 10/09/2017 à 13:23, Michael Brohl a écrit : I think if we have code which is not used or planned to be used, it should be removed. Since we agreed on deprecating minilang, no code is allowed to be commited using minilang

Re: Extend type entities to add name of detail entity where hasTable is true.

-1 from my side, I think we can solve this by convention instead of introducing a new field. Thanks, Michael Am 01.09.17 um 15:53 schrieb Vaibhav Jain: +1 for introducing new attribute "tableName". Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Fri, Sep 1, 2017 at 5:16

Re: Extend type entities to add name of detail entity where hasTable is true.

Hi Arun, thanks for reporting this. I think we should keep the convention and fix the metioned types. Introducing a new field to specify the detail table should not be necessary. Thanks, Michael Am 01.09.17 um 13:18 schrieb Arun Patidar: Hello All, 'hasTable' field of 'Type' entities is

Re: Services with no definition and usage

I think if we have code which is not used or planned to be used, it should be removed. Since we agreed on deprecating minilang, no code is allowed to be commited using minilang with the exception of a bug fix. We shoul be very restrictive in this case. I agree that we should first provide a

Re: Tracking Data Model changes

+1 for the documentation of database changes. We alreadyy do this for customer projects, along with (database specific) data migration scripts. I'm not sure if we can afford to provide sophisticated additional tool support which is maintained continiously? As a conclusion, I think we

Re: New website

Hi Sharan, I agree on the FAQ issue. It really needs some care... Thanks, Michael Am 28.08.17 um 11:33 schrieb Sharan Foga: Hi Jacques Thanks, the new website was an amazing collaborative effort from quite a few people, so I am not going to take all the credit for it :-) For the carousel

Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration

+1 Looking forward to the design proposal. You can use the wiki with a new page under https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals to provide the details and support collaboration. Thanks, Michael Am 26.08.17 um 13:31 schrieb Pritam Kute: Hi

Re: Updating our OFBiz Blog Template

Hi Sharan, great, this looks much better now, especially with the bigger font size. I'm not sure, but how about making it look more like our new website? Thanks and regards, Michael Am 24.08.17 um 18:46 schrieb Sharan Foga: Hi Everyone I've received some feedback (and a link) from Kenneth

Re: Common-theme next step

Thank you, Nicolas, for the great effort you put on this. I'll hope to soon reactivate my work on the bootstrap theme, using the new structure, and see how it will work out. I'll have some more qualified feedback (and propably questions ;-) ) then... Thanks, Michael Am 25.08.17 um 12:15

Re: Importance of programming in our community

Hi Michael, everyone concerned, Le 10/09/2017 à 11:41, Michael Brohl a écrit : Hi Taher, I agree with the general sight on these issues. Regarding the point functionals vs. programmers: I'm not even sure if we have a significant number of these people in the community? I guess most of them

Re: Importance of programming in our community

Hi Taher, I agree with the general sight on these issues. Regarding the point functionals vs. programmers: I'm not even sure if we have a significant number of these people in the community? I guess most of them are also programmers. And if we have them, I think it will be hard to motivate

Re: Importance of programming in our community

A big +1 On Mon, Sep 4, 2017 at 4:17 PM Taher Alkhateeb wrote: > Hello everyone, > > I've been thinking for a few weeks about this topic, so I thought I'd > just share my thoughts here. > > OFBiz has great DSL, it is a blessing, it makes things easier > OFBiz has

Re: Improper permission check on screens

Big +1 for the proposal. Thanks & Regards, Devanshu Vyas. On Thu, Aug 31, 2017 at 7:10 PM, Rishi Solanki wrote: > Suraj, > > Thanks for the detailed description, and it would be nice to have this > change. > +1 for the proposal, with caution below; > > We have actions

Re: Importance of programming in our community

Hello Taher, Thanks Taher for your thoughts, and I am in agreement with you. Writing code in DSL make its easier for newbies but learning/understanding the framework takes time and needs more care. We all should be working toward a better framework with more generic purpose programming language