I guess you mean
Le 12/06/2018 à 15:54, Taher Alkhateeb a écrit :
I'm no longer interested in discussing this, I already explained it.
-1 on the comment
-1 on the removal
+1 on excluding the transitive dependency
If you want to fix things for BIRT, I recommend you do it_outside_
the
I'm currently reviewing
http://svn.apache.org/viewvc?view=revision=1834389
http://svn.apache.org/viewvc?view=revision=1834465
I'll get back to this later, but I'm surprised that it would be an issue, it's
just simple and fast to review... unlike above...
Jacques
Le 29/06/2018 à 16:11,
Ahh, so you just decided to ignore my input?
On Fri, Jun 29, 2018, 3:28 PM Jacques Le Roux
wrote:
> Hi All,
>
> Do we need a vote here to decide if we should ask infra or not?
>
> Else I'll tomorrow consider the last exchange with Scott 2 weeks ago a
> lazy consensus and will simply replace
I refactored many parts of the framework. I might have done more
refactoring than anyone recently.
However, I never just pushed a commit. I always ask for feedback, I make a
patch and I consistently ask for people's feedback, some of that feedback
came directly from you Jacques.
So for you to
Hi All,
Do we need a vote here to decide if we should ask infra or not?
Else I'll tomorrow consider the last exchange with Scott 2 weeks ago a lazy
consensus and will simply replace using
- compile 'com.lowagie:itext:4.2.0'
+ compile 'com.lowagie:itext:2.1.7' // don't update
Michael
It's not a change just a refactorization. I thought it was simple enough to be committed. If we go this way for simple and small changes like here
things will be quite slow
I also answered in the Jira since you also asked the same there
Jacques
Le 29/06/2018 à 12:21, Michael Brohl
Jacques,
didn't we just agreed upon a slower process and review from more
committers when changing these core aspects of the framework?
Especially when you change the patch there is no chance for anyone to
review before it gets committed {#emotions_dlg.sad}
Michael
Am 29.06.18 um 12:03
Many Congratulations Swapnil !!
Thanks & Regards,
Swapnil
-Original Message-
From: Jacques Le Roux
Sent: Wednesday, June 27, 2018 1:31 AM
To: dev@ofbiz.apache.org
Subject: Welcome to Swapnil M. Mane as new committer!
The OFBiz PMC has invited Swapnil to become a new committer and we
Many Congratulations Aditya !!
Thanks & Regards,
Swapnil
-Original Message-
From: Jacques Le Roux
Sent: Wednesday, June 27, 2018 1:30 AM
To: dev@ofbiz.apache.org
Subject: Welcome to Aditya Sharma as new committer!
The OFBiz PMC has invited Aditya to become a new committer and we
Many Congratulations Suraj !!
Thanks & Regards,
Swapnil
-Original Message-
From: Jacques Le Roux
Sent: Wednesday, June 27, 2018 1:30 AM
To: dev@ofbiz.apache.org
Subject: Welcome to Suraj Khurana as new committer!
The OFBiz PMC has invited Suraj to become a new committer and we
10 matches
Mail list logo