Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Ritesh Kumar
Thanks, Girish for clearly explaining my concern and everyone for your inputs. I have created the ticket ( OFBIZ-10539 ). Soon, I will be providing the solution patch for review. On Sun, Aug 26, 2018 at 3:36 PM Michael Brohl wrote: > OFBiz

Re: Old demo restarted

2018-08-26 Thread Jacques Le Roux
Le 26/08/2018 à 12:52, Taher Alkhateeb a écrit : VisualVM is a desktop application, So is YourKit, as long as they are accessible and free and to any committer I don't see the problem. Can't you install that on your machine to help? JMX is a specification and set of libraries / specs. So I

Re: Old demo restarted

2018-08-26 Thread Taher Alkhateeb
VisualVM is a desktop application, JMX is a specification and set of libraries / specs. So I think both are not suitable. I'm not going to read through your email with all these links as that's confusing and boring. You asked for my help, and now you're again participating in this thread (the

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Michael Brohl
OFBiz handles multiple request parameters with the same name well if you use POST requests. For GET requests, there seem to be no standard for multiple parameters with the same name, see [1]. I thinks it would be good to investigate further and see if we can fix this. I don't see a problem

Re: Old demo restarted

2018-08-26 Thread Jacques Le Roux
Thanks Taher, Why did you not consider VisualVM and JMX (apart that it would be more work)? Do we need a complex tool to do this task (report alerts, allow simple post-mortem)? Have you something else in mind? Also, as I said at https://markmail.org/message/byu2ivjn7wckayzz After using

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Jacques Le Roux
Thanks Girish for your detailed analysis! Jacques Le 26/08/2018 à 06:57, Girish Vasmatkar a écrit : Hi Ritesh It does look like an issue to me. I believe (correct me if I am wrong) it is not so much about whether GET is appropriate here, it is more about that the framework is unable to

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Jacques Le Roux
Le 26/08/2018 à 11:20, Mathieu Lirzin a écrit : Taher Alkhateeb writes: Hmmm, based on Girish's feedback I think perhaps the next step should be to open a JIRA and further investigate. Thinking about it some more, maybe this would have an impact on the REST API project we're working on. The

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-26 Thread Jacques Le Roux
Hi Taher, Thanks for your review, much appreciated. Le 22/08/2018 à 18:42, Taher Alkhateeb a écrit : I reviewed the code and explanation in the beginning of this thread and I have the following comments: - First, in case of a result.containsKey(ModelService.ERROR_MESSAGE) you are still

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Mathieu Lirzin
Taher Alkhateeb writes: > Hmmm, based on Girish's feedback I think perhaps the next step should be to > open a JIRA and further investigate. Thinking about it some more, maybe > this would have an impact on the REST API project we're working on. The issue seems indeed related. +1 for a opening