Nicolas Malin writes:
> On 8/10/19 12:07 AM, Mathieu Lirzin wrote:
>
>> Here are a few inline comments regarding the code.
>>
>> Maybe I overlooked some good reason justifying some design decision you
>> made, so if you want to discuss more about the suggestions I proposed,
>> we can do some
Jacques Le Roux writes:
> Done
Thanks Jacques.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Thanks Jacopo
-1
checksum OK, tests OK, runs OK
Before being able to run tests and OFBiz, like you Jacopo, I had to add
org.gradle.jvmargs="-Xmx512m" in a gradle.properties file (for me in Gradle
home)
I wonder if it's not related to the Gradle version installed.
After seeing that Swapnil
Actually no error there either:
https://ci.apache.org/projects/ofbiz/logs/17.12/framework/html/
Le 11/08/2019 à 15:34, build...@apache.org a écrit :
The Buildbot has detected a new failure on builder ofbizBranch17Framework while
building . Full details are available at:
Done
Le 10/08/2019 à 19:29, Jacques Le Roux a écrit :
Makes sense Mathieu,
I'll...
Jacques
Le 10/08/2019 à 18:43, Mathieu Lirzin a écrit :
Hello Jacques,
jler...@apache.org writes:
- File dir = new File(imageServerPath + dirPath);
+ File dir = new
On 8/10/19 12:07 AM, Mathieu Lirzin wrote:
Hello Nicolas,
Hi man,
Here are a few inline comments regarding the code.
Maybe I overlooked some good reason justifying some design decision you
made, so if you want to discuss more about the suggestions I proposed,
we can do some pair programming
Same here
+1
On 8/10/19 4:30 PM, Taher Alkhateeb wrote:
All tests are clear, smoke tests clear, SHA512 checksum matches
+1 from my side. Thank you for your efforts Jacopo
On Sat, Aug 10, 2019 at 12:17 PM Jacopo Cappellato
wrote:
This is the vote thread to release a new bug fix release
OK, locally
Le 10/08/2019 à 20:29, build...@apache.org a écrit :
The Buildbot has detected a new failure on builder
ofbizBranch17FrameworkPlugins while building . Full details are available at:
https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/362
Buildbot URL:
