Re: Nested attributes for Collection Types

2020-07-16 Thread Pritam Kute
Hello Girish, IMO, the option which you have suggested looks good in case if we want to leverage upon the existing service definitions for creating the API documentation. I also think that this could be a good addition to OFBiz in the developer perspective, as right now, it is very difficult to

Re: Error.ftl everywhere

2020-07-16 Thread Jacques Le Roux
Hi Nicolas, All, Last effort: I think we should now get rid of all error.jsp, error403.jsp and error404.jsp files and all references to these. It's easy to remove commented out references from 3 web.xml files (marketing, partymgr and workeffort). We are sure they are not used. Then it makes

Re: JavaScript Source Maps

2020-07-16 Thread Jacques Le Roux
Le 16/07/2020 à 15:01, Jacques Le Roux a écrit : https://issues.apache.org/jira/issues/?jql=project %3D OFBIZ AND text ~ "map alex" This url is easier to use: https://s.apache.org/xzdtx

JavaScript Source Maps

2020-07-16 Thread Jacques Le Roux
Hi, Alex Bodnaru has started an effort to fix issues with javascript minification and javaScript source maps[1]: https://issues.apache.org/jira/issues/?jql=project %3D OFBIZ AND text ~ "map alex" For now he is working on R17. I see no pb to backport JavaScript Source Maps adds and changes

Re: API Reference on OFBiz site

2020-07-16 Thread Jacques Le Roux
Hi Pawan, That looks good but we have a problem with the menu Documentation/API Reference Jacques Le 16/07/2020 à 14:12, Pritam Kute a écrit : Thanks, Pawan. Looks good to me. Kind Regards, -- Pritam Kute On Thu, Jul 16, 2020 at 5:24 PM Devanshu Vyas wrote: Looks good to me. Thanks &

Re: API Reference on OFBiz site

2020-07-16 Thread Pritam Kute
Thanks, Pawan. Looks good to me. Kind Regards, -- Pritam Kute On Thu, Jul 16, 2020 at 5:24 PM Devanshu Vyas wrote: > Looks good to me. > > Thanks & Regards, > Devanshu Vyas. > > > On Thu, Jul 16, 2020 at 4:42 PM Pawan Verma > > wrote: > > > Changes are live now, please have a look at > >

Re: API Reference on OFBiz site

2020-07-16 Thread Devanshu Vyas
Looks good to me. Thanks & Regards, Devanshu Vyas. On Thu, Jul 16, 2020 at 4:42 PM Pawan Verma wrote: > Changes are live now, please have a look at > https://ofbiz.apache.org/developers.html#DevDocs > > If we are good here the ticket can be closed now. > -- > Thanks & Regards > Pawan Verma >

Nested attributes for Collection Types

2020-07-16 Thread Girish Vasmatkar
Hey Guys, While working on OpenApi integration as well as GraphQL implementation, I faced issues on how to automatically document request/response JSON structure for service attributes that were of Collection types (Map, List etc). For simple types, it is just plain easy but when it comes to

Re: API Reference on OFBiz site

2020-07-16 Thread Pawan Verma
Changes are live now, please have a look at https://ofbiz.apache.org/developers.html#DevDocs If we are good here the ticket can be closed now. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Thu, Jul 16,

Re: API Reference on OFBiz site

2020-07-16 Thread Jacques Le Roux
+1 Jacques Le 16/07/2020 à 11:43, Pawan Verma a écrit : Thanks, Jacques, All for the response. Yes, Makes sense. So, It will look something like this, if this looks good, I'll make the required changes. The layout of API Reference on the Site: *OFBiz API Reference* - *Trunk API

Re: Error.ftl everywhere

2020-07-16 Thread Nicolas Malin
Thanks Jacques, You finished the work to remove the jsp error :) Nicolas On 15/07/2020 21:09, Jacques Le Roux wrote: > > Le 05/07/2020 à 16:50, Jacques Le Roux a écrit : >> Hi, >> >> While working on OFBIZ-11840 I thought about the solution I used for >> "[CVE-2020-1943] Apache OFBiz XSS

Re: API Reference on OFBiz site

2020-07-16 Thread Pawan Verma
Thanks, Jacques, All for the response. Yes, Makes sense. So, It will look something like this, if this looks good, I'll make the required changes. The layout of API Reference on the Site: *OFBiz API Reference* - *Trunk API Reference* - *Release 17.12 API Reference* - *Next Release API

Re: API Reference on OFBiz site

2020-07-16 Thread Jacques Le Roux
Hi Pawan, Indeed, next is for now more an internal concept. But, like it's now clear for stable - thanks to the demo, we could explain this concept to users. It's simple: the next branch to be released. This would prevent to have to modify (and often forget) the real reference, ie R18 for now.

Re: API Reference on OFBiz site

2020-07-16 Thread Pawan Verma
Hi Jacques, Yes, seems like a good idea to expose the next API too. But I am not fully aware of the next API and curious about the label means Next API Reference, wouldn't it be confusing for the user? -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source