Re: checkNewPassword and ignoreCurrentPassword

2020-07-18 Thread Jacques Le Roux
Le 18/07/2020 à 11:34, Jacques Le Roux a écrit : Le 13/07/2020 à 14:50, Jacques Le Roux a écrit : Something related I already shared in the security ML: I guess we don't want to change (I don't mean the NOTE but the feature).    // NOTE: must check permission first so that admin users can set

Re: checkNewPassword and ignoreCurrentPassword

2020-07-18 Thread Jacques Le Roux
Le 13/07/2020 à 14:50, Jacques Le Roux a écrit : Something related I already shared in the security ML: I guess we don't want to change (I don't mean the NOTE but the feature).    // NOTE: must check permission first so that admin users can set own password without specifying old password I

Re: Error.ftl everywhere

2020-07-18 Thread Jacques Le Roux
Le 16/07/2020 à 17:20, Jacques Le Roux a écrit : Then it makes sense to remove RequestHandler::getDefaultErrorPage and its only reference in ControlServlet::handle (since nothing exists in web.xml files) I rather made error.ftl the new default Done Jacques

Re: Single line statements - checkstyle

2020-07-18 Thread Jacques Le Roux
Le 14/07/2020 à 10:15, Jacques Le Roux a écrit : My conclusion is that could be discussed again and I for one I'm not against changing this rule for 2 reasons: 1.      We can't use our current formatter to do it right 2.      With a single line statement there are less chances to confuse and