Re: Checkstyle line wrapping Indentation

2020-07-21 Thread Jacques Le Roux
+1 reading the link Thanks Suraj! Le 21/07/2020 à 14:21, Pritam Kute a écrit : Good catch Suraj. +1 for having it as 4 instead of 8. Kind Regards, -- Pritam Kute On Tue, Jul 21, 2020 at 5:26 PM Suraj Khurana wrote: Hello folks, In checkstyle.xml, we have set lineWrappingIndentation

Re: Checkstyle line wrapping Indentation

2020-07-21 Thread Pritam Kute
Good catch Suraj. +1 for having it as 4 instead of 8. Kind Regards, -- Pritam Kute On Tue, Jul 21, 2020 at 5:26 PM Suraj Khurana wrote: > Hello folks, > > In checkstyle.xml, we have set lineWrappingIndentation value to 8. I > Propose we should make it 4 instead which is default. [1] > > Is

Re: Update Gradle in trunk

2020-07-21 Thread Nicolas Malin
Hi Jacques, Thanks for your alert, I will take some time to check the new UI dans correct the process. Nicolas On 21/07/2020 10:15, Jacques Le Roux wrote: > Hi Nicolas, All, > > I tried to update Gradle in trunk following >

Checkstyle line wrapping Indentation

2020-07-21 Thread Suraj Khurana
Hello folks, In checkstyle.xml, we have set lineWrappingIndentation value to 8. I Propose we should make it 4 instead which is default. [1] Is there any specific reason for setting it to 8? Please advise. [1]:

Update Gradle in trunk

2020-07-21 Thread Jacques Le Roux
Hi Nicolas, All, I tried to update Gradle in trunk following https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray rather than doing it by hand, mostly to test the process by my own. But the UI has changed. There is no longer an "*Upload* link, hidden on

Re: Ordering Decimals

2020-07-21 Thread Jacques Le Roux
Le 21/07/2020 à 09:29, Suraj Khurana a écrit : Also, if we agree for product store level configuration, it should be entertaining in a similar manner as we have done for requireInventory (Check service isStoreInventoryRequiredInline). Means, giving priority to product level configuration and

Re: Ordering Decimals

2020-07-21 Thread Suraj Khurana
Hi, +1 to have some products in demo data with decimal quantity configuration. Also, if we agree for product store level configuration, it should be entertaining in a similar manner as we have done for requireInventory (Check service isStoreInventoryRequiredInline). Means, giving priority to

Re: Ordering Decimals

2020-07-21 Thread Pawan Verma
+1 for setting orderDecimalQuantity to N in demo data and introduce some(at least 2-3) demo decimal quantity products. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Tue, Jul 21, 2020 at 12:21 PM Jacques Le

Re: Ordering Decimals

2020-07-21 Thread Jacques Le Roux
Hi Pritam, Le 21/07/2020 à 08:13, Pritam Kute a écrit : I think its a good idea to have orderDecimalQuantity set to N for the products in demo data. What I have noticed in demo data is there is no practical product data available for which we can set this flag to Y. IMO, we can add one or two

Re: Documentation "issues"

2020-07-21 Thread Jacques Le Roux
Hi Eugen, Inline... Le 20/07/2020 à 12:34, Eugen Stan a écrit : Hi, I think it's great that you are migration your docs to AsciiDoc. What are you using to publish them? Buildbot launches Gradle AsciiDoc tasks.

Re: Ordering Decimals

2020-07-21 Thread Pritam Kute
I think its a good idea to have orderDecimalQuantity set to N for the products in demo data. What I have noticed in demo data is there is no practical product data available for which we can set this flag to Y. IMO, we can add one or two demo products that can be ordered in decimal quantities.