Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-08-02 Thread Suraj Khurana
All good on the local machine. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Aug 3, 2020 at 10:15 AM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are > available at: >

Re: ParameterNumber checkstyle rule

2020-08-02 Thread Suraj Khurana
Thanks Jacques. 10 looks good to me as well. I have created a Jira and uploaded patch for this: https://issues.apache.org/jira/browse/OFBIZ-11931 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote:

Re: MethodLength checkstyle rule

2020-08-02 Thread Suraj Khurana
Thanks Jacques, I think we can go with 500, I have uploaded the patch on the ticket (OFBIZ-11915). -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:06 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > Has I had no ideas about the

Re: REST implementation

2020-08-02 Thread Girish Vasmatkar
Hi Daniel You can use the JWT token in the README of. Sorry, if it is not clearly documented, this will be improved upon further as I make more changes. https://github.com/girishvasmatkar/ofbiz-plugins/tree/trunk/ofbiz-rest-impl I need to implement an API endpoint that eventually generates a JWT

Re: REST implementation

2020-08-02 Thread Girish Vasmatkar
Hi Jacques Thanks for taking a look at this. Since, REST does not define any WSDL, rather WADL, we can try to show it, however, since it is a component as a starting point, it would probably be good if we can show WADL, if and when it gets included in the framework. Because request coming to

Re: REST implementation

2020-08-02 Thread Daniel Watford
Hi Girish, I wanted to try out some REST calls using Swagger-ui ( https://localhost:8443/docs/swagger-ui.html) but don't know how to authenticate to get a JWT. Apologies if I missed the instructions elsewhere but please could you advise on how to authenticate against the REST api? Thanks, Dan.

Re: REST implementation

2020-08-02 Thread Jacques Le Roux
At https://localhost:8443/rest/ I get a 404 and in log javax.ws.rs.NotFoundException: HTTP 404 Not Found     at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:250)     at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)     at

Re: REST implementation

2020-08-02 Thread Jacques Le Roux
I get that we have this information at https://localhost:8443/docs/swagger-ui.html like with https://localhost:8443/docs/swagger-ui.html#/Exported%20Services/findProductById So I guess we can put a link to that, rigth? Also there is no of...@apache.org (at

Re: REST implementation

2020-08-02 Thread Jacques Le Roux
Not a big deal, saw that when applying as a patch: git apply 35.patch 35.patch:364: trailing whitespace. * GET /rest/services/{serviceName}?inParams= 35.patch:765: trailing whitespace.     xmlns:xl="http://www.w3.org/1999/xlink; 35.patch:2813: trailing whitespace. 35.patch:486: new blank line

Re: REST implementation

2020-08-02 Thread Jacques Le Roux
Hi Girish, I'm just starting to review so I may miss things. Just a question for now. We have an option at https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceList?sel_service_name=testScv to  (Show wsdl