Re: OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

2021-02-09 Thread Nicolas Malin
Hello Daniel, I'm a little confuse to take more than 6 month to response. You push me on my currently java knowledge limit, and after analyze I didn't understand all you done. However, your works feel good. During my works on the OFBIZ-11810 [1], I confronted to many duplicated code between

Re: Blacklist and whitelist replacements

2021-02-09 Thread Jacques Le Roux
Hi, With OFBIZ-12167 I have done the easy cases. I had a look at master and, even if it's not related to slave in contexts, I think that main could be used instead in most places. This said I'm not opinionated on that. Mostly because it's a lot of boring work I must confess ;) Jacques Le

Re: Adding flexibility to condition-service in seca/eeca rules

2021-02-09 Thread Nicolas Malin
Hello Suraj, On your project case, your suggest is a good way to solve quickly your constraint, but you also create a second service that call the first that negate the result.  * isSalesOrder  * isNotSalesOrder After I'm more in favor to refactoring all conditions on seca and eeca to follow